-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor XR Privacy Agreement UI for XRPF 2.0 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the XR Privacy Framework for version 2.0, introducing a redesigned, theme-customizable privacy agreement UI and adding support for audio permissions. The minimum Unity version requirement has been updated from 2019.4 to 2021.3 to align with Unity SDK 2.0 compatibility.
Key Changes:
- Added audio data permission support across the entire framework
- Completely refactored PrivacyAgreementCanvas component with customizable theming system
- Enhanced Foldout component with theme color application methods
- Introduced new UI shaders and materials for gradient and radial glow effects
Reviewed changes
Copilot reviewed 33 out of 52 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumped version to 2.0.0 and updated minimum Unity requirement to 2021.3 |
| Runtime/XRPrivacyFramework.cs | Added IsAudioDataAllowed property to interfaces and agreement classes; updated SetNewAgreement signature |
| Samples~/CodeSamples/SaveToPreferences.cs | Added audio field to preferences class and updated serialization/deserialization logic |
| Samples~/AgreementPopup/Scripts/PrivacyAgreementCanvas.cs | Complete rewrite with ColorTheme system, theme application methods, and editor inspector customization |
| Samples~/AgreementPopup/Scripts/Foldout.cs | Added SetThemeColors, UpdateVisualState, and OnToggleValueChanged methods for theme support |
| Samples~/AgreementPopup/Content/* | Added new UI shaders (UIGradient, UIRadialGlow), materials, sprites, and icon assets |
| Samples~/AgreementPopup/Content/DataSourcePanel.prefab | Updated prefab with new UI structure, icons, improved layout, and theme-aware components |
Comments suppressed due to low confidence (1)
Samples~/CodeSamples/SaveToPreferences.cs:25
- The format string ignores this supplied value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
removed foldout logic renamed shaders to xrpf
This PR includes updates and improvements for XRPF 2.0:
PrivacyAgreementCanvascomponent