[#547] Harden oracle median and freshness validation - #566
Open
greatest0fallt1me wants to merge 2 commits into
Open
greatest0fallt1me wants to merge 2 commits into
greatest0fallt1me wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acceptance criteria
Design notes
Each source has one observation per asset.
get_price_validaggregates source metadata when present, requiring the configured quorum of whitelisted and fresh sources. Values are normalized to the highest observed precision and insertion-sorted without relying on Address ordering. The even-count midpoint uses a difference-first calculation to avoid overflowing on large prices, and the result timestamp is the oldest accepted observation.Verification
git diff --checkpasses.cargo test -p price_oraclewas attempted but is currently blocked before test compilation by the repository dependencyethnum v1.5.2using an invalid zero-sized transmute with rustc 1.97.1.Compatibility
Existing single-source deployments continue to work with the default quorum of one. Existing assets with only legacy
Price(asset)storage remain readable until source metadata is published. Once source metadata exists, quorum failure does not fall back to the legacy snapshot.Closes #547