Repository navigation
Remove code and comments left over from the SQLite engine - #1201
Merged
Merged
Conversation
Deleted connectorstore.ExpansionGrantLister and ListGrantsWithExpansion. rg over non-vendor code found no implementer: only the declaration, the type assert in pkg/c1zsanitize/ledger_run.go, and the same assert in expansion_roundtrip_test.go. Both call sites now use ListGrants. Co-authored-by: Cursor <cursoragent@cursor.com>
dump-db is named in docs/verification plans, so the command stays. Deleted the v1 branch that decoded a c1z with NewC1ZFileDecoder and copied the SQLite payload to a file. Non-v3 input now errors. v3 still extracts the Pebble payload directory via ExtractEnvelopePayload. NewC1ZFileDecoder stays: pkg/dotc1z/sqlite/open.go is the remaining caller. Co-authored-by: Cursor <cursoragent@cursor.com>
Deleted the SQLite alternative from NewExpanderStore, GrantsForEntitlementPrincipalSorted, grantByRefsDeleter, and grantsByRefsBatchDeleter in syncer.go, and from the storeCaps header, the deleter-field comment, and the readerCaps header in store_caps.go. The SQLite engine is gone (PR #1193); Pebble is the only engine, so those clauses described an implementation that no longer exists. No code in store_caps.go changed. Co-authored-by: Cursor <cursoragent@cursor.com>
No non-test code produces StoreMetadata.Engine \"sqlite\" (rg '"sqlite"' under pkg, excluding tests, hits only sql.Open in pkg/dotc1z/sqlite and this comment). Removed that value from the Engine comment. Kept the v1 format line: ReadHeaderFormat still returns C1ZFormatV1 and pkg/dotc1z/sqlite/open.go requires it, and the payload is still SQLite. DBSizeProvider no longer names a sqlite file; the Pebble engine sums regular files in its database directory. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Superseded — see the current review report for commit
|
Contributor
General PR Review: Remove SQLite-era dead code and comments from pkg/sync, c1zsanitize, dump-dbBlocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0 Review SummaryThis PR deletes the exported Risk triage (criteria):
How the criteria applied:
No references to Security IssuesNone found. Correctness IssuesNone found. Suggestions
Prompt for AI agentsReviewed commit: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No blocking issues found — see the full review report
kans
changed the title
ggreer
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four independent commits, no behaviour change for Pebble files.
connectorstore.ExpansionGrantListerhad no implementer once the SQLite engine was removed. Deleted;c1zsanitizeand its test callListGrantsdirectly.TestSanitizeGrantExpansionRoundTripstill assertsGrantExpandablesurvives sanitize.baton dump-dbrejects anything but v3 instead of carrying the v1 decoder path. Kept (hidden command) because the verification docs reference it.pkg/sync/syncer.go,store_caps.goandconnectorstore.gothat described SQLite as the other engine, or listed"sqlite"as anEnginevalue, lose those clauses.To review: the two
ListGrantscall sites and thedump-dbguard. The rest is comment text.Heads-up for the next c1 bump:
cmd/dev-util/build_grants_c1z.gotype-assertsExpansionGrantLister; delete that branch, itsListGrantsfallback is already there.