Install bumped version of node if needed 💿#151
Merged
AdrieanKhisbe merged 1 commit intomasterfrom Apr 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/bump-dependencies.js:23
- Using 'nvm install' without specifying a node version might lead to inconsistent behavior if multiple node versions exist. Consider specifying the target version (e.g., 'nvm install ') or ensuring the environment definitively sets the version needed.
const LOAD_NVM = '. ${NVM_DIR:-$HOME/.nvm}/nvm.sh && (nvm use || nvm install)'; // eslint-disable-line no-template-curly-in-string
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 75.08% 75.08%
=======================================
Files 19 19
Lines 618 618
=======================================
Hits 464 464
Misses 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
silouone
approved these changes
Apr 4, 2025
esa-coorp
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, you need to install the new node version you're trying to setup 😅