Skip to content

revert add banner#31

Merged
prajwal-pai77 merged 1 commit intomasterfrom
add-ga-analytics
Apr 21, 2026
Merged

revert add banner#31
prajwal-pai77 merged 1 commit intomasterfrom
add-ga-analytics

Conversation

@prajwal-pai77
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds OneTrust cookie consent scripts to the Docusaurus configuration. The review identifies a contradiction between the PR title and the implementation, and notes a potential domain mismatch for the OneTrust script ID which could lead to functional issues.

Comment on lines +33 to +51
// OneTrust Cookies Consent Notice for couchbase.com
headTags: [
{
tagName: 'script',
attributes: {
src: 'https://cdn.cookielaw.org/scripttemplates/otSDKStub.js',
type: 'text/javascript',
charset: 'UTF-8',
'data-domain-script': '748511ff-10bf-44bf-88b8-36382e5b5fd9',
},
},
{
tagName: 'script',
attributes: {
type: 'text/javascript',
},
innerHTML: 'function OptanonWrapper() {}',
},
],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request title "revert add banner" contradicts the code changes, which are adding the OneTrust cookie consent scripts. If the intention was to remove the banner, these lines should be deleted. If the intention was to add the banner, the PR title should be updated to reflect the correct action.

locales: ['en'],
},

// OneTrust Cookies Consent Notice for couchbase.com
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment mentions "couchbase.com", which differs from the site's configured domain "ruby-cb-orm.com" (line 11). OneTrust configurations are typically domain-specific; using an ID intended for a different domain will prevent the consent banner from appearing or functioning correctly.

@prajwal-pai77 prajwal-pai77 merged commit 01f8280 into master Apr 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant