Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds OneTrust cookie consent scripts to the Docusaurus configuration. The review identifies a contradiction between the PR title and the implementation, and notes a potential domain mismatch for the OneTrust script ID which could lead to functional issues.
Comment on lines
+33
to
+51
| // OneTrust Cookies Consent Notice for couchbase.com | ||
| headTags: [ | ||
| { | ||
| tagName: 'script', | ||
| attributes: { | ||
| src: 'https://cdn.cookielaw.org/scripttemplates/otSDKStub.js', | ||
| type: 'text/javascript', | ||
| charset: 'UTF-8', | ||
| 'data-domain-script': '748511ff-10bf-44bf-88b8-36382e5b5fd9', | ||
| }, | ||
| }, | ||
| { | ||
| tagName: 'script', | ||
| attributes: { | ||
| type: 'text/javascript', | ||
| }, | ||
| innerHTML: 'function OptanonWrapper() {}', | ||
| }, | ||
| ], |
There was a problem hiding this comment.
The pull request title "revert add banner" contradicts the code changes, which are adding the OneTrust cookie consent scripts. If the intention was to remove the banner, these lines should be deleted. If the intention was to add the banner, the PR title should be updated to reflect the correct action.
| locales: ['en'], | ||
| }, | ||
|
|
||
| // OneTrust Cookies Consent Notice for couchbase.com |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.