ci: bump ci.yml action pin, allow bot PR reviews, fix release-prepare#60
Merged
Conversation
The release-prepare workflow updated README action-usage pins but not ci.yml's own two `.../report@vX.Y.Z` references, so this repo's CI kept pinning the report action to a stale version after every release (as just happened: category support shipped in the action, but ci.yml still referenced @v0.3.0, which predates it). Requires workflows: write since the release commit now touches a file under .github/workflows/. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
demo-coveragetracker-dev | c52caf3 | Commit Preview URL Branch Preview URL |
Jul 07 2026, 02:35 AM |
- Manually bump ci.yml's two report-action pins from @v0.3.0 to @v0.4.0 ahead of the v0.4.0 tag, since release/v0.4.0 was already branched before the release-prepare.yml fix in this PR existed to do it automatically. - Add allowed_bots to claude-code-review.yml so Dependabot and Copilot PRs get reviewed instead of skipped. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tbjers
changed the title
release-prepare.yml (and the manual bump in this PR) pins ci.yml's report-action reference to the version being released before its tag exists, so any PR against a release/vX.Y.Z branch fails at action resolution. Skip the Report coverage step in that case; it still runs normally on PRs against main and on push (post-merge, once the tag is live). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This reverts commit e33f152.
Step-level `if:` doesn't work here — GitHub Actions resolves every `uses:` reference in a job during job setup regardless of each step's condition, so the just-bumped-but-not-yet-tagged report-action pin still fails resolution even when the step using it is skipped. Excluding release/** as a pull_request base branch prevents the workflow from starting at all, which is the only way to avoid it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This reverts commit 3569380.
Point both Report coverage steps at ./.github/actions/report instead of a pinned CoverageTracker/coverage-tracker/.../report@vX.Y.Z tag. This repo dogfoods its own action, so it should run the exact code on the current branch rather than a released version — and a local path never needs resolving a tag/branch at all, which permanently removes the catch-22 where release-prep bumped this pin ahead of the tag existing. Reverts the now-unnecessary release-prepare.yml changes (ci.yml pin bumping, workflows: write) since there's no longer a pin here to bump. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tbjers
added a commit
that referenced
this pull request
Jul 7, 2026
* chore(release): v0.4.0 * ci: reference the report action by local path, not a version pin (#60) * ci: reference the report action by local path, not a version pin Point both Report coverage steps at ./.github/actions/report instead of a pinned CoverageTracker/coverage-tracker/.../report@vX.Y.Z tag. This repo dogfoods its own action, so it should run the exact code on the current branch rather than a released version — and a local path never needs resolving a tag/branch at all, which permanently removes the catch-22 where release-prep bumped this pin ahead of the tag existing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Torgny Bjers <torgny@bjers.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retargeted onto
release/v0.4.0(#59) so v0.4.0 tags correctly instead of carrying a stale action pin.release-prepare.ymlnow also bumps.github/workflows/ci.yml's two.../report@vX.Y.Zpins (previously only the README pins were updated), and gainedworkflows: writepermission (the verified-commit GraphQL call rejects writes under.github/workflows/without it).ci.yml's two pins from@v0.3.0to@v0.4.0directly, sincerelease/v0.4.0was branched before this fix existed —categorysupport shipped in the action butci.ymlstill referenced the pre-category@v0.3.0.allowed_bots: "dependabot[bot],copilot[bot]"toclaude-code-review.ymlso Dependabot/Copilot PRs get reviewed instead of skipped.Test plan
sedpattern used byrelease-prepare.ymlagainst a copy ofci.yml— both pins bump correctly, no unintended matches.ci.ymlnow pins@v0.4.0directly in this branch.🤖 Generated with Claude Code