Preserve connect block order on rehash - #257
Merged
Merged
Conversation
eaescob
marked this pull request as ready for review
May 19, 2026 16:39
crigler
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates
merge_connects()so/rehashrebuilds the active connect list in the order theconnect {}blocks appear in the configuration file.Previously, a fresh startup effectively restored config order because
new_connectswas built by head insertion and then inserted intoconnectsby head insertion again. During/rehash, however, existing named connect blocks were updated in place, so reordering unchangedconnect {}blocks in the config did not affect the active connect list until restart.The active connect list matters for autoconnect behavior:
try_connections()scansconnectsfrom the head and attempts only the first eligible uplink during a pass, then rotates that attempted entry to the end.Changes
new_connectslist before merging so it is processed in config-file order.aConnectobjects so active references are preserved.Validation
git diff --checkeescobar@ircwithautoreconf -vfi,./configure --prefix=$HOME/dalnet/ircd, andmake -j$(nproc).connect {}blocks, issued/rehash, and confirmed/stats cchanged fromuplink-a, uplink-btouplink-b, uplink-awithout restart.