Open
Conversation
- Remove unused query parameter from SkillTable.sel (accidentally re-added in refactor) - Prefix unused **kwargs in gridded_skill methods with underscore - Remove leftover model parameter from ComparerCollectionPlotter.hist (forgotten during deprecation cleanup) - Remove leftover model parameter from ComparerPlotter.scatter (forgotten during deprecation cleanup) - Fix _std_obs and _std_mod: prefix unused params with underscore, update type hints to Any - Prefix unused norm and figsize parameters in _scatter_plotly with underscore - Prefix unused _ax parameter in taylor_diagram with underscore - Remove unused name parameter from _obs_from_dict (name already in obs_dict) - Enable ARG (unused argument) checks in ruff configuration
ecomodeller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all unused arguments in the codebase (11 total) and enables ARG checks in ruff.
Changes
Removed entirely:
SkillTable.sel(query=...)- accidentally re-added in refactor a8a1c92, was properly removed in 7f8434bComparerCollectionPlotter.hist(model=...)- leftover from deprecation cleanup in 7f8434bComparerPlotter.scatter(model=...)- leftover from deprecation cleanup in 7f8434b_obs_from_dict(name, ...)- redundant, name already in obs_dictPrefixed with underscore (intentionally unused):
gridded_skill(**_kwargs)- reserved for future use_std_obs(_model)/_std_mod(_obs)- metric API requires (obs, model) signature, updated type hints toAny_scatter_plotly(_norm, _figsize)- matplotlib-only params, kept for API consistencytaylor_diagram(_ax)- not yet implementedConfig:
"ARG"to ruff lint rulesBreaking Changes
Removed
modelparameter from.plot.hist()and.plot.scatter()(was already non-functional since Dec 2024).Use
.sel(model=...)before plotting instead.