Merged
Conversation
jpalm3r
reviewed
Feb 4, 2026
Contributor
jpalm3r
left a comment
jpalm3r
left a comment
There was a problem hiding this comment.
I am trying to render the documentation locally and it fails because some paths do not exist. For example, in the second cell of Directional_data_comparison.qmd, ..\data\wave_dir.dfs0 does not exist. Maybe it should be ..\tests\testdata\wave_dir.dfs0?
Member
Author
|
❯ ls -l docs/data
lrwxrwxrwx 1 jan jan 17 Sep 19 15:08 docs/data -> ../tests/testdataYou can try to run it in GitHub Codespace. |
jpalm3r
approved these changes
Feb 5, 2026
Contributor
jpalm3r
left a comment
jpalm3r
left a comment
There was a problem hiding this comment.
I have just checked with codespaces and everything worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt documentation to changes in #533