fix(rust_brain): preserve HLC on snapshot restore and gossip receive#46
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(rust_brain): preserve HLC on snapshot restore and gossip receive#46cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
After snapshot restore, nodes were assigned fresh HLC timestamps instead of the stored values from the snapshot. Post-restore causal writes with legitimate successor HLCs were rejected as TimestampRegression, causing silent data loss in disaster-recovery and multi-node gossip scenarios. - Add _parse_hlc() for snapshot/wire HLC normalisation - Restore HLC on snapshot load and advance global _hlc - Pass HLC through bulk_write and gossip receive - Reject stale gossip updates; skip HLC-less updates on existing keys - Add regression tests for restore round-trip and gossip ordering Co-authored-by: Daniel <DJLougen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Critical data-loss bug in disaster recovery and multi-node gossip.
After
restore_from_file(), nodes were assigned fresh HLC timestamps instead of the values stored in the snapshot. Legitimate post-restore causal writes with successor HLCs were rejected asTimestampRegression, causing silent data loss.Similarly,
GossipProtocol.receive()ignored HLC timestamps from peers, allowing stale gossip events to overwrite fresher local state.Concrete trigger scenario
remember("k", "v1", hlc=(5000, 10, "nodeA"))(wall, 0, uuid)instead of(5000, 10, "nodeA")remember("k", "v2", hlc=(5000, 11, "nodeA"))raisesTimestampRegression— write silently lostRoot cause
restore_from_file()reconstructedMemoryNodewithout passing thehlcfield from the snapshot JSON.MemoryNodedefaulted to_hlc.now(), producing unrelated timestamps.gossip.receive()also omitted HLC passthrough.Fix
_parse_hlc()for snapshot/wire HLC normalisation (with legacy fallback for pre-v0.6.0 snapshots)_hlcvia_hlc.update()bulk_writeandgossip.receive()restore_from_fileandgc_expiredValidation
TimestampRegressiontest_restore_preserves_hlc_for_replication, 4 gossip HLC tests