Enhancement standalone type uint8#1900
Open
lukasdreyer wants to merge 5 commits intostandalone-scheme-typesfrom
Open
Enhancement standalone type uint8#1900lukasdreyer wants to merge 5 commits intostandalone-scheme-typesfrom
lukasdreyer wants to merge 5 commits intostandalone-scheme-typesfrom
Conversation
4627031 to
ae47355
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## standalone-scheme-types #1900 +/- ##
========================================================
Coverage 76.15% 76.15%
========================================================
Files 103 103
Lines 19423 19424 +1
========================================================
+ Hits 14791 14792 +1
Misses 4632 4632 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f219b33 to
2fd0b6a
Compare
ae57747 to
c5e2676
Compare
Davknapp
reviewed
Nov 21, 2025
| using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>; | ||
| //template <t8_eclass TEclass> | ||
| //using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>; | ||
| //using t8_element_type = u_int8_t; |
Collaborator
There was a problem hiding this comment.
why are you not using this line? It would add a little bit of context to the data-type, especially when it is used as return-type.
|
|
||
| template <t8_eclass TEclass> | ||
| using t8_element_type = std::bitset<T8_ELEMENT_NUM_EQUATIONS[TEclass]>; | ||
| //template <t8_eclass TEclass> |
Collaborator
There was a problem hiding this comment.
If you don't use these lines, please delete them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).