Skip to content

Feature: test upper lower search#2159

Draft
holke wants to merge 4 commits intofeature-ancestor_searchfrom
feature-test_upper_lower_search
Draft

Feature: test upper lower search#2159
holke wants to merge 4 commits intofeature-ancestor_searchfrom
feature-test_upper_lower_search

Conversation

@holke
Copy link
Collaborator

@holke holke commented Feb 3, 2026

Describe your changes here:

Closes #2112 and #2113.
Implemented test cases for t8_forest_bin_search_lower and upper.

For both functions we iterate over all cmeshes, build a uniform and adaptive forest on it and run the following test:

  • For each element of the forest, try to find it
  • For each element E of the forest construct an element E' that is not in the element array but searching for it will find E
  • For each tree construct one element such that searching for it will not find any element

Additional features that i added:

  • A new test header for commonly used adapt functions (Since now an adapt function is shared among tests)
  • A pretty print function was put inside the test_macros header since it is now shared between 2 tests.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@holke holke changed the base branch from main to feature-ancestor_search February 3, 2026 13:49
@holke holke requested a review from Davknapp February 3, 2026 13:49
@holke holke marked this pull request as draft February 3, 2026 13:50
@holke
Copy link
Collaborator Author

holke commented Feb 3, 2026

Completely messed up git here.
Need to rebase the ancestor branch properly.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.92%. Comparing base (a69cde4) to head (410083c).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature-ancestor_search    #2159   +/-   ##
========================================================
  Coverage                    77.92%   77.92%           
========================================================
  Files                          113      113           
  Lines                        19154    19154           
========================================================
  Hits                         14926    14926           
  Misses                        4228     4228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a test for t8_forest_bin_search_lower

1 participant