Skip to content

Fix: __WD_UpdateExtractor reporting success before copy completes - #553

Open
Danp2 wants to merge 1 commit into
masterfrom
fix/updateextractor-verify-copy
Open

Fix: __WD_UpdateExtractor reporting success before copy completes#553
Danp2 wants to merge 1 commit into
masterfrom
fix/updateextractor-verify-copy

Conversation

@Danp2

@Danp2 Danp2 commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Pull request

Proposed changes

$bEXEWasFound was set True merely from finding a matching .exe entry in the zip listing, before Shell.Application's CopyHere() (which runs asynchronously) had actually placed the file.

Combined with the old driver being deleted first, a silent copy failure (locked file, AV interference, permission error) left the install directory with no driver at all while _WD_UpdateDriver still reported success.

Now wait (bounded, 10s) for the destination file to appear and base success on that instead.

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!

This is simply a reminder of what we are going to look for before merging your code.

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

What is the new behavior?

Please describe the behavior or changes that are being added by this PR.

Influences and relationship to other functionality

Describe how the changes will affect other functions, potential script breaking changes, etc.

Additional context

Add any other context about the problem here.

System under test

Please complete the following information.

  • OS: [e.g. Windows 10]
  • OS Arch.: [e.g. X64]
  • Browser [e.g. firefox]
  • Browser version [e.g. 96.0.3]

$bEXEWasFound was set True merely from finding a matching .exe entry
in the zip listing, before Shell.Application's CopyHere() (which
runs asynchronously) had actually placed the file. Combined with the
old driver being deleted first, a silent copy failure (locked file,
AV interference, permission error) left the install directory with
no driver at all while _WD_UpdateDriver still reported success. Now
wait (bounded, 10s) for the destination file to appear and base
success on that instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant