Fix: _WD_CapabilitiesAdd wiping vendor object on empty primitive value - #557
Open
Danp2 wants to merge 1 commit into
Open
Fix: _WD_CapabilitiesAdd wiping vendor object on empty primitive value#557Danp2 wants to merge 1 commit into
Danp2 wants to merge 1 commit into
Conversation
In the SPECIFICVENDOR_PRIMITIVE branch, the capability key name was
only appended to the JSON notation when $value1 was non-empty. Since
$value1 defaults to '' when the caller omits it, a call like
_WD_CapabilitiesAdd('detach') left $s_Notation pointing at the whole
vendor-options object (e.g. "ms:edgeOptions"), and the subsequent
Json_Put() replaced that entire object with '', destroying any
previously-added sibling capabilities (args, prefs, etc). Always
append the key, matching the unconditional behavior already used by
the neighboring SPECIFICVENDOR_ARRAY/SPECIFICVENDOR_OBJECT branches.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Proposed changes
In the SPECIFICVENDOR_PRIMITIVE branch, the capability key name was only appended to the JSON notation when $value1 was non-empty. Since $value1 defaults to '' when the caller omits it, a call like _WD_CapabilitiesAdd('detach') left $s_Notation pointing at the whole vendor-options object (e.g. "ms:edgeOptions"), and the subsequent Json_Put() replaced that entire object with '', destroying any previously-added sibling capabilities (args, prefs, etc).
Always append the key, matching the unconditional behavior already used by the neighboring SPECIFICVENDOR_ARRAY/SPECIFICVENDOR_OBJECT branches.
Checklist
Put an
xin the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!This is simply a reminder of what we are going to look for before merging your code.
Types of changes
Please check
xthe type of change your PR introduces:What is the current behavior?
Please describe the current behavior that you are modifying, or link to a relevant issue.
What is the new behavior?
Please describe the behavior or changes that are being added by this PR.
Influences and relationship to other functionality
Describe how the changes will affect other functions, potential script breaking changes, etc.
Additional context
Add any other context about the problem here.
System under test
Please complete the following information.