Add LocalTimeSnapshot, parsing helpers, and doc/path updates#229
Merged
Conversation
Introduce a portable LocalTimeSnapshot in mm_util.h and replace direct localtime usage with snapshot-based APIs across several modules (timestamp/screenshot formatting, clock entity, debug logging) to improve portability and avoid duplicate calls. Add MM_TrimAsciiWhitespace and strengthen parsing helpers in mm_parse.h (std::string_view support, safer int/float/quoted parsing and embedded-null detection), and update mm_loc_parse.h to use string_view, trimmed/quoted body handling, and the new float parsing. Rename private Horde AdaptiveState members to camelCase for internal consistency. Update tests to cover trimming and parsing edge cases. Refresh various docs and changelog references to the new src/sgame/ tree and adjust in-doc source-path examples.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5472ea863
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a portable LocalTimeSnapshot in mm_util.h and replace direct localtime usage with snapshot-based APIs across several modules (timestamp/screenshot formatting, clock entity, debug logging) to improve portability and avoid duplicate calls. Add MM_TrimAsciiWhitespace and strengthen parsing helpers in mm_parse.h (std::string_view support, safer int/float/quoted parsing and embedded-null detection), and update mm_loc_parse.h to use string_view, trimmed/quoted body handling, and the new float parsing. Rename private Horde AdaptiveState members to camelCase for internal consistency. Update tests to cover trimming and parsing edge cases. Refresh various docs and changelog references to the new src/sgame/ tree and adjust in-doc source-path examples.