This repository was archived by the owner on Apr 29, 2020. It is now read-only.
Audit all damage type values in BLU spells.#6412
Open
mrhappyasthma wants to merge 1 commit intoDarkstarProject:masterfrom
mrhappyasthma:bludamagetype
Open
Audit all damage type values in BLU spells.#6412mrhappyasthma wants to merge 1 commit intoDarkstarProject:masterfrom mrhappyasthma:bludamagetype
mrhappyasthma wants to merge 1 commit intoDarkstarProject:masterfrom
mrhappyasthma:bludamagetype
Conversation
Corrects /adds any inaccurate or missing damage types. Also updated the param value in the Lua table to use `damageType` instead of `dmgtype`. This better matches the enum value naming convention for `dsp.damageType`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects /adds any inaccurate or missing damage types.
Also updated the param value in the Lua table to use
damageTypeinstead of
dmgtype. This better matches the enum value namingconvention for
dsp.damageType.This is part of the ongoing cleanup needed for #6225.