perf: cache workspace monitoring profile (30s TTL) - #191
Open
quinneydavid wants to merge 1 commit into
Open
Conversation
get_workspace_monitoring_profile() is called once per data row by the energy/power/battery history builders, and each call created a fresh SQLAlchemy engine and reflected the entire schema (get_table_names) before reading one row. On a populated DB, single-day history requests took 5-13s and concurrent requests fully serialized. Cache the result for 30s and invalidate it from the only write path that changes monitoring_profile (update_initial_setup_options). Measured on a 41k-row single-UPS install: /api/energy/data?period=today 6.8s -> 0.11s 4 concurrent requests 27.5s -> 0.45s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_workspace_monitoring_profile() is called once per data row by the energy/power/battery history builders, and each call created a fresh SQLAlchemy engine and reflected the entire schema (get_table_names) before reading one row. On a populated DB, single-day history requests took 5-13s and concurrent requests fully serialized.
Cache the result for 30s and invalidate it from the only write path that changes monitoring_profile (update_initial_setup_options).
Measured on a 41k-row single-UPS install:
/api/energy/data?period=today 6.8s -> 0.11s
4 concurrent requests 27.5s -> 0.45s