Skip to content

[DT-3755] instant approval legend on data library#3718

Open
jlaw-codes wants to merge 5 commits into
developfrom
lawson-dt-3755-auto-dar-approval-insight-on-library
Open

[DT-3755] instant approval legend on data library#3718
jlaw-codes wants to merge 5 commits into
developfrom
lawson-dt-3755-auto-dar-approval-insight-on-library

Conversation

@jlaw-codes

@jlaw-codes jlaw-codes commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-3755
https://broadworkbench.atlassian.net/browse/DT-3786

Summary

After

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@jlaw-codes jlaw-codes requested a review from a team as a code owner July 4, 2026 19:21
@jlaw-codes jlaw-codes requested review from fboulnois and rushtong and removed request for a team July 4, 2026 19:21
@jlaw-codes jlaw-codes changed the title instant approval legend on data library [DT-3755] instant approval legend on data library Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for DUOS Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.7% 9873 / 11520
🔵 Statements 85.15% 10468 / 12294
🔵 Functions 81.66% 2871 / 3516
🔵 Branches 77.11% 5977 / 7751
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/data_library/InstantApprovalBadge.tsx 100% 100% 100% 100%
src/components/data_library/LibraryPageShell.tsx 85.71% 84.61% 33.33% 85.71% 135
src/pages/DataLibrary.tsx 91.3% 94.44% 91.66% 90.9% 86, 97-98, 125-126, 133
src/pages/DatasetStatistics.tsx 80.76% 85.71% 85.71% 80.76% 59-67, 71-81, 126-133, 142-143, 175
src/utils/DatasetUtils.ts 100% 100% 100% 100%
Generated in workflow #6289 for commit ae9dea5 by the Vitest Coverage Report Action

@fboulnois fboulnois left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as advertised - see comments inline.

Comment thread src/components/data_library/LibraryPageShell.tsx Outdated
Comment thread src/pages/DataLibrary.tsx
@sonarqubecloud

Copy link
Copy Markdown

@rushtong rushtong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants