SSV-25461 High latency due to ZFSin driver#111
Draft
datacore-PankajSharma wants to merge 15 commits intodatacore-windowsfrom
Draft
SSV-25461 High latency due to ZFSin driver#111datacore-PankajSharma wants to merge 15 commits intodatacore-windowsfrom
datacore-PankajSharma wants to merge 15 commits intodatacore-windowsfrom
Conversation
Registry 'zfs_abd_prealloc_percent' can be used to set the percent of prealloc wrt zfs_arc_max
…oc_percent Setting zfs_prealloc_percent=0 will disable the prealloc feature
arun-kv
reviewed
Apr 30, 2026
| delta = ddi_get_lbolt() - start; | ||
| spa_txg_history_fini_io(spa, ts); | ||
|
|
||
| /* ◄── ADC: feed measured delta into controller. |
There was a problem hiding this comment.
Can you please remove "◄──" this special charecters from the code
Collaborator
Author
There was a problem hiding this comment.
Done
| mutex_exit(&tx->tx_sync_lock); | ||
|
|
||
| txg_stat_t *ts = spa_txg_history_init_io(spa, txg, dp); | ||
| int64_t dirty_flushed = spa->spa_dsl_pool->dp_dirty_pertxg[txg & TXG_MASK]; |
There was a problem hiding this comment.
Can you also add "dp_dirty_total".
Ideally accessing dp_dirty_pertxg should be under lock, in this case it may be okay as we just need approximate value.
Collaborator
Author
There was a problem hiding this comment.
Done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.