Skip to content

chore(rshell): bump to demo-stack pre-release for image build - #50418

Closed
julesmcrt wants to merge 4 commits into
mainfrom
jules.macret/rshell-demo-stack
Closed

chore(rshell): bump to demo-stack pre-release for image build#50418
julesmcrt wants to merge 4 commits into
mainfrom
jules.macret/rshell-demo-stack

Conversation

@julesmcrt

Copy link
Copy Markdown
Contributor

Summary

Pins github.com/DataDog/rshell to the tip of the unmerged jules.macret/host-remediation/truncate branch (commit 2acb2e80f23a) so GitLab CI produces an agent image that includes the in-flight rshell features for a disk-space remediation demo:

Why draft

Not for merge. The pinned rshell commit is on a feature branch and the upstream changes are themselves still under review. This PR exists purely so CI builds and publishes an image we can pull into a Linux VM for end-to-end testing.

Test plan

  • Wait for the agent image build job in GitLab CI
  • Pull the resulting image into a Linux VM
  • Run PAR self-enrollment, drive the disk-space remediation demo from the Datadog UI

🤖 Generated with Claude Code

Pins rshell to the tip of the host-remediation/truncate branch
(unmerged) so CI builds an agent image that exercises the in-flight
sandbox-write, file redirection, and truncate features for a
disk-space remediation demo. Not for merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label May 6, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label May 6, 2026
@dd-octo-sts

dd-octo-sts Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Go Package Import Differences

Baseline: 6d20614
Comparison: b227fd1

binaryosarchchange
privateactionrunnerlinuxamd64
+7, -0
+github.com/DataDog/rshell/builtins/df
+github.com/DataDog/rshell/builtins/du
+github.com/DataDog/rshell/builtins/logrotate
+github.com/DataDog/rshell/builtins/pwd
+github.com/DataDog/rshell/builtins/read
+github.com/DataDog/rshell/builtins/truncate
+github.com/DataDog/rshell/builtins/xargs
privateactionrunnerlinuxarm64
+7, -0
+github.com/DataDog/rshell/builtins/df
+github.com/DataDog/rshell/builtins/du
+github.com/DataDog/rshell/builtins/logrotate
+github.com/DataDog/rshell/builtins/pwd
+github.com/DataDog/rshell/builtins/read
+github.com/DataDog/rshell/builtins/truncate
+github.com/DataDog/rshell/builtins/xargs
privateactionrunnerwindowsamd64
+7, -0
+github.com/DataDog/rshell/builtins/df
+github.com/DataDog/rshell/builtins/du
+github.com/DataDog/rshell/builtins/logrotate
+github.com/DataDog/rshell/builtins/pwd
+github.com/DataDog/rshell/builtins/read
+github.com/DataDog/rshell/builtins/truncate
+github.com/DataDog/rshell/builtins/xargs
privateactionrunnerdarwinamd64
+7, -0
+github.com/DataDog/rshell/builtins/df
+github.com/DataDog/rshell/builtins/du
+github.com/DataDog/rshell/builtins/logrotate
+github.com/DataDog/rshell/builtins/pwd
+github.com/DataDog/rshell/builtins/read
+github.com/DataDog/rshell/builtins/truncate
+github.com/DataDog/rshell/builtins/xargs
privateactionrunnerdarwinarm64
+7, -0
+github.com/DataDog/rshell/builtins/df
+github.com/DataDog/rshell/builtins/du
+github.com/DataDog/rshell/builtins/logrotate
+github.com/DataDog/rshell/builtins/pwd
+github.com/DataDog/rshell/builtins/read
+github.com/DataDog/rshell/builtins/truncate
+github.com/DataDog/rshell/builtins/xargs

@dd-octo-sts

dd-octo-sts Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 6d20614a:

Results for datadog-agent_7.80.0~devel.git.574.b227fd1.pipeline.113705214-1_amd64.deb:

No change detected

@datadog-official

datadog-official Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 50.14% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b227fd1 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6d20614
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 742.797 → 750.310
agent_deb_amd64_fips N/A N/A → 700.625 → 702.690
agent_heroku_amd64 N/A N/A → 309.246 → 313.960
agent_rpm_amd64 N/A N/A → 742.780 → 750.280
agent_rpm_amd64_fips N/A N/A → 700.609 → 702.670
agent_rpm_arm64 N/A N/A → 720.668 → 724.050
agent_rpm_arm64_fips N/A N/A → 681.600 → 684.460
agent_suse_amd64 N/A N/A → 742.780 → 750.280
agent_suse_amd64_fips N/A N/A → 700.609 → 702.670
agent_suse_arm64 N/A N/A → 720.668 → 724.050
agent_suse_arm64_fips N/A N/A → 681.600 → 684.460
docker_agent_amd64 N/A N/A → 802.986 → 805.870
docker_agent_arm64 N/A N/A → 805.706 → 809.730
docker_agent_jmx_amd64 N/A N/A → 993.905 → 996.590
docker_agent_jmx_arm64 N/A N/A → 985.405 → 989.410
docker_cluster_agent_amd64 N/A N/A → 206.658 → 207.600
docker_cluster_agent_arm64 N/A N/A → 220.697 → 221.150
docker_cws_instrumentation_amd64 N/A N/A → 7.142 → 7.180
docker_cws_instrumentation_arm64 N/A N/A → 6.689 → 6.920
docker_host_profiler_amd64 N/A N/A → 302.171 → 315.800
docker_host_profiler_arm64 N/A N/A → 313.666 → 327.400
docker_dogstatsd_amd64 N/A N/A → 39.507 → 39.540
docker_dogstatsd_arm64 N/A N/A → 37.690 → 38.080
dogstatsd_deb_amd64 N/A N/A → 30.161 → 30.770
dogstatsd_deb_arm64 N/A N/A → 28.291 → 29.270
dogstatsd_rpm_amd64 N/A N/A → 30.161 → 30.770
dogstatsd_suse_amd64 N/A N/A → 30.161 → 30.770
iot_agent_deb_amd64 N/A N/A → 44.517 → 44.970
iot_agent_deb_arm64 N/A N/A → 41.494 → 42.560
iot_agent_deb_armhf N/A N/A → 42.230 → 42.740
iot_agent_rpm_amd64 N/A N/A → 44.518 → 44.970
iot_agent_suse_amd64 N/A N/A → 44.518 → 44.970

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented May 6, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 90f60768-4df5-4e48-a437-345181940788

Baseline: 18ff3c1
Comparison: 7c8cdc8
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.06 [-1.96, +4.09] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.54 [+1.55, +3.53] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +1.06 [-1.96, +4.09] 1 Logs
quality_gate_security_idle memory utilization +0.40 [+0.32, +0.47] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.39 [+0.23, +0.54] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.29 [+0.24, +0.34] 1 Logs
docker_containers_memory memory utilization +0.29 [+0.19, +0.39] 1 Logs
quality_gate_security_mean_fs_load memory utilization +0.22 [+0.19, +0.26] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.22 [+0.11, +0.33] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.17 [-0.08, +0.43] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.12 [+0.07, +0.18] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.50, +0.56] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.44, +0.45] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.10, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.17, +0.15] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.41, +0.40] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.21, +0.19] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.22, +0.18] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.09 [-0.24, +0.07] 1 Logs
quality_gate_idle_all_features memory utilization -0.13 [-0.17, -0.09] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.20 [-0.24, -0.15] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.27 [-0.36, -0.17] 1 Logs
ddot_metrics_sum_delta memory utilization -0.47 [-0.66, -0.28] 1 Logs
ddot_metrics memory utilization -0.48 [-0.68, -0.28] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.73 [-0.97, -0.50] 1 Logs
tcp_syslog_to_blackhole ingress throughput -3.50 [-3.71, -3.28] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 693 ≥ 26
docker_containers_memory memory_usage 10/10 244.65MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 680 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 141.70MiB ≤ 147MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 472.78MiB ≤ 495MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 174.77MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 423.35 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 383.47MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 22.89 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 288.42MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 54.75 ≤ 70 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 267.29MiB ≤ 320MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 19.83 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 277.88MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@julesmcrt julesmcrt closed this May 6, 2026
Updates the rshell pin to the tip of jules.macret/host-remediation/logrotate-host-exec
(commit d4bd28b3), which now includes df + du from main, the merged sort -h fix,
plus the demo-stack chain (allowed-paths-writes, file-redirection, truncate,
host-binary exec). Triggers a fresh CI agent image build for the
disk-space remediation demo. Not for merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@julesmcrt julesmcrt reopened this May 7, 2026
julesmcrt and others added 2 commits May 7, 2026 14:49
Picks up rshell 8b1b308 which closes the logrotate threshold-check
TOCTOU via Sandbox.TruncateIfLarger.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dd-octo-sts

dd-octo-sts Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

@dd-octo-sts dd-octo-sts Bot added the stale label Jun 2, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This pull request was automatically closed because it has been stale for 15 days with no activity.

If this pull request is still relevant, please reopen it or create a new pull request with updated information.

Thanks!

@dd-octo-sts dd-octo-sts Bot closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-closed internal Identify a non-fork PR short review PR is simple enough to be reviewed quickly stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant