Skip to content

feat(otel-metrics): share SDK trace stats mapping - #54906

Draft
mabdinur wants to merge 4 commits into
mainfrom
codex/sdk-trace-stats-mapping
Draft

feat(otel-metrics): share SDK trace stats mapping#54906
mabdinur wants to merge 4 commits into
mainfrom
codex/sdk-trace-stats-mapping

Conversation

@mabdinur

@mabdinur mabdinur commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a transport-neutral sdktracestats package under opentelemetry-mapping-go. BuildSDKTraceStatsPayload owns SDK metric recognition, field mapping, validation, normalized tags, time windows, per-datapoint error isolation, and lossless sparse-histogram construction.

The caller supplies envelope metadata such as source and hostname. The package returns shared APM-stats fields without depending on the Agent or dd-source protobuf types.

Motivation

The Agent and public OTLP metrics intake need to convert traces.span.sdk.metrics.duration into the same APM trace-stats contract. Keeping two mappings would let tags, status handling, histogram validation, and operation naming drift. This PR makes one mapping implementation the source of truth while leaving transport adapters and delivery local to each consumer.

Stack and shipping order

  1. This PR merges first as the shared code dependency.
  2. ddoghq/dd-source#56526 and DataDog/datadog-agent#53167 then consume it and can be reviewed in parallel.
  3. ddoghq/dd-go#8800 can merge independently, but it must deploy before feat(otel-metrics): materialize SDK trace histograms as APM stats #53167 rolls out. The dd-source rollout does not depend on dd-go.

Scope

  • Delta histograms only; the mapping keeps no cumulative-to-delta state.
  • Invalid datapoints are skipped without discarding valid datapoints in the same metric.
  • Exact explicit histogram data is preserved in sparse-sketch fields.
  • No protobuf, HTTP, routing, or deployment behavior is introduced here.

Validation

  • dda inv test --targets=./pkg/opentelemetry-mapping-go/otlp/metrics/...
  • bazel test //pkg/opentelemetry-mapping-go/otlp/metrics/sdktracestats:sdktracestats_test

Both suites pass. Contract coverage includes field mapping, tag normalization, explicit histograms, invalid-datapoint isolation, temporality filtering, fallback windows, and large sparse-bin counts.

Review focus

  • Shared field and tag semantics.
  • Validation/error-isolation behavior.
  • The boundary between shared mapping logic and consumer-owned transport code.

@github-actions

Copy link
Copy Markdown
Contributor

@codex review

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-build team/agent-apm trace-agent labels Aug 14, 2026
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label Aug 14, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76505711df

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread pkg/opentelemetry-mapping-go/otlp/metrics/sdktracestats/sdk_trace_stats.go Outdated
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 78.37%
Overall Coverage: 52.40% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f887f24 | Docs | Datadog PR Page | Give us feedback!

@mabdinur
mabdinur force-pushed the codex/sdk-trace-stats-mapping branch from 7650571 to 6a5264f Compare August 14, 2026 16:42
@github-actions github-actions Bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Aug 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3b2688f
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 759.615 → 764.500
agent_deb_amd64_fips N/A N/A → 712.472 → 715.740
agent_heroku_amd64 N/A N/A → 311.955 → 319.050
agent_msi N/A N/A → 643.578 → 660.960
agent_rpm_amd64 N/A N/A → 759.599 → 764.470
agent_rpm_amd64_fips N/A N/A → 712.456 → 715.740
agent_rpm_arm64 N/A N/A → 735.360 → 736.540
agent_rpm_arm64_fips N/A N/A → 691.547 → 693.690
agent_suse_amd64 N/A N/A → 759.599 → 764.470
agent_suse_amd64_fips N/A N/A → 712.456 → 715.740
agent_suse_arm64 N/A N/A → 735.360 → 736.540
agent_suse_arm64_fips N/A N/A → 691.547 → 693.690
docker_agent_amd64 N/A N/A → 818.231 → 820.040
docker_agent_arm64 N/A N/A → 819.035 → 820.740
docker_agent_jmx_amd64 N/A N/A → 1009.128 → 1010.800
docker_agent_jmx_arm64 N/A N/A → 998.585 → 1000.420
docker_cluster_agent_amd64 N/A N/A → 210.475 → 211.300
docker_cluster_agent_arm64 N/A N/A → 223.456 → 223.810
docker_cws_instrumentation_amd64 N/A N/A → 7.439 → 7.480
docker_cws_instrumentation_arm64 N/A N/A → 6.877 → 7.110
docker_dogstatsd_amd64 N/A N/A → 39.482 → 39.960
docker_dogstatsd_arm64 N/A N/A → 37.560 → 38.270
docker_host_profiler_amd64 N/A N/A → 305.814 → 317.690
docker_host_profiler_arm64 N/A N/A → 317.125 → 328.970
dogstatsd_deb_amd64 N/A N/A → 30.224 → 31.200
dogstatsd_deb_arm64 N/A N/A → 28.247 → 29.580
dogstatsd_rpm_amd64 N/A N/A → 30.224 → 31.200
dogstatsd_suse_amd64 N/A N/A → 30.224 → 31.200
iot_agent_deb_amd64 N/A N/A → 46.467 → 47.530
iot_agent_deb_arm64 N/A N/A → 43.124 → 44.200
iot_agent_deb_armhf N/A N/A → 43.907 → 44.990
iot_agent_rpm_amd64 N/A N/A → 46.468 → 47.530
iot_agent_suse_amd64 N/A N/A → 46.467 → 47.530

@mabdinur
mabdinur force-pushed the codex/sdk-trace-stats-mapping branch from 6a5264f to 71896a4 Compare August 14, 2026 17:00
@github-actions github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Aug 14, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 14, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: b74adcd3-eabe-40f1-a09d-cdcc9095f9da

Baseline: 3b2688f
Comparison: f887f24
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_mean_fs_load memory utilization +0.33 [+0.25, +0.41] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.18 [+0.07, +0.30] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.08 [-0.06, +0.23] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.05 [-0.18, +0.07] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.21 [-0.26, -0.17] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.50 [-0.60, -0.39] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.72 [-0.96, -0.47] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.61 [-3.50, -1.72] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.57MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 741.34KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 521.26MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 203.88MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.81MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 361.38 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 16 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 394.70MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.95MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 32.54 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 329.12MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 66.13 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 305.29MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.69 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 310.24MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@mabdinur mabdinur added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant