chore: remove singleton private access - #670
Open
ava-silver wants to merge 2 commits into
Open
Conversation
ava-silver
commented
Aug 14, 2026
Comment on lines
-308
to
-321
| function extractSingletonFunctions(lambdaFunctions: LambdaFunction[]): lambda.Function[] { | ||
| // extract lambdaFunction property from Singleton Function | ||
| // using bracket notation here since lambdaFunction is a private property | ||
| const extractedLambdaFunctions: lambda.Function[] = lambdaFunctions.map((fn) => { | ||
| // eslint-disable-next-line dot-notation | ||
| return isSingletonFunction(fn) ? fn["lambdaFunction"] : fn; | ||
| }); | ||
|
|
||
| return extractedLambdaFunctions; | ||
| } | ||
|
|
||
| function isSingletonFunction(fn: LambdaFunction): fn is lambda.SingletonFunction { | ||
| return fn.hasOwnProperty("lambdaFunction"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is the problematic access we're trying to avoid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes access to CDK's private
SingletonFunction.lambdaFunctionfield.Motivation
Avoid coupling singleton instrumentation to CDK implementation details.
Singleton support originally unwrapped its backing Lambda so the existing
Function-only instrumentation paths could be reused. The backing field is private, so this change uses publicSingletonFunctionAPIs and its documentedpermissionsNodefor the generated L1 resource when needed. These were introduced in 2023, and the code only existed since they weren't available before.Testing Guidelines
yarn test-- 245 passing tests.66ff1bf: logs and traces.Types of Changes
Check all that apply