perf(metrics): remove per-send completion promises - #820
Merged
Conversation
Each DogStatsD send allocated a promise although dgram already reports completion through its callback. A generation counter prevents late callbacks from a timed-out flush from completing a later flush. Sampled allocations decreased by 18.60 MiB across 5,000 invocations (1.835%).
|
Error callbacks and synchronous send failures must settle without falling through to the flush timeout.
joeyzhao2018
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track DogStatsD completion through socket callbacks instead of allocating and retaining one promise per send. A flush creates one promise and timeout only while sends remain.
A generation counter isolates callbacks from timed-out flushes. Sampled allocations decreased by 18.60 MiB across 5,000 invocations (1.835%).