-
Notifications
You must be signed in to change notification settings - Fork 321
Support DD_LOG_FORMAT_JSON
#10223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DD_LOG_FORMAT_JSON
#10223
Conversation
2fcaa95 to
233d1ae
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088493
Total [baseline] (8.762 s) : 0, 8762342
Agent [candidate] (1.08 s) : 0, 1079992
Total [candidate] (8.719 s) : 0, 8719015
section iast
Agent [baseline] (1.219 s) : 0, 1219204
Total [baseline] (9.372 s) : 0, 9371610
Agent [candidate] (1.228 s) : 0, 1228221
Total [candidate] (9.384 s) : 0, 9384100
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (653.374 ms) : 0, 653374
BytebuddyAgent [candidate] (648.548 ms) : 0, 648548
GlobalTracer [baseline] (284.029 ms) : 0, 284029
GlobalTracer [candidate] (282.301 ms) : 0, 282301
AppSec [baseline] (32.645 ms) : 0, 32645
AppSec [candidate] (32.293 ms) : 0, 32293
Debugger [baseline] (67.428 ms) : 0, 67428
Debugger [candidate] (66.81 ms) : 0, 66810
Remote Config [baseline] (630.429 µs) : 0, 630
Remote Config [candidate] (612.877 µs) : 0, 613
Telemetry [baseline] (9.846 ms) : 0, 9846
Telemetry [candidate] (9.017 ms) : 0, 9017
Flare Poller [baseline] (3.739 ms) : 0, 3739
Flare Poller [candidate] (3.709 ms) : 0, 3709
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (788.246 ms) : 0, 788246
BytebuddyAgent [candidate] (794.599 ms) : 0, 794599
GlobalTracer [baseline] (255.719 ms) : 0, 255719
GlobalTracer [candidate] (257.508 ms) : 0, 257508
AppSec [baseline] (31.849 ms) : 0, 31849
AppSec [candidate] (33.713 ms) : 0, 33713
Debugger [baseline] (67.613 ms) : 0, 67613
Debugger [candidate] (66.012 ms) : 0, 66012
Remote Config [baseline] (584.355 µs) : 0, 584
Remote Config [candidate] (591.391 µs) : 0, 591
Telemetry [baseline] (8.369 ms) : 0, 8369
Telemetry [candidate] (8.448 ms) : 0, 8448
Flare Poller [baseline] (3.485 ms) : 0, 3485
Flare Poller [candidate] (3.522 ms) : 0, 3522
IAST [baseline] (26.894 ms) : 0, 26894
IAST [candidate] (27.193 ms) : 0, 27193
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086621
Total [baseline] (10.909 s) : 0, 10908963
Agent [candidate] (1.082 s) : 0, 1082069
Total [candidate] (10.826 s) : 0, 10826067
section appsec
Agent [baseline] (1.272 s) : 0, 1272341
Total [baseline] (10.933 s) : 0, 10933027
Agent [candidate] (1.273 s) : 0, 1272879
Total [candidate] (11.028 s) : 0, 11028474
section iast
Agent [baseline] (1.224 s) : 0, 1223960
Total [baseline] (11.184 s) : 0, 11183922
Agent [candidate] (1.231 s) : 0, 1230541
Total [candidate] (11.149 s) : 0, 11149285
section profiling
Agent [baseline] (1.207 s) : 0, 1207388
Total [baseline] (10.954 s) : 0, 10954073
Agent [candidate] (1.202 s) : 0, 1201745
Total [candidate] (10.923 s) : 0, 10923444
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (652.287 ms) : 0, 652287
BytebuddyAgent [candidate] (649.372 ms) : 0, 649372
GlobalTracer [baseline] (283.621 ms) : 0, 283621
GlobalTracer [candidate] (282.598 ms) : 0, 282598
AppSec [baseline] (32.594 ms) : 0, 32594
AppSec [candidate] (32.423 ms) : 0, 32423
Debugger [baseline] (67.977 ms) : 0, 67977
Debugger [candidate] (67.778 ms) : 0, 67778
Remote Config [baseline] (625.804 µs) : 0, 626
Remote Config [candidate] (615.133 µs) : 0, 615
Telemetry [baseline] (8.989 ms) : 0, 8989
Telemetry [candidate] (8.987 ms) : 0, 8987
Flare Poller [baseline] (3.797 ms) : 0, 3797
Flare Poller [candidate] (3.698 ms) : 0, 3698
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (694.449 ms) : 0, 694449
BytebuddyAgent [candidate] (694.13 ms) : 0, 694130
GlobalTracer [baseline] (260.708 ms) : 0, 260708
GlobalTracer [candidate] (260.546 ms) : 0, 260546
AppSec [baseline] (174.789 ms) : 0, 174789
AppSec [candidate] (175.518 ms) : 0, 175518
Debugger [baseline] (67.072 ms) : 0, 67072
Debugger [candidate] (67.368 ms) : 0, 67368
Remote Config [baseline] (723.378 µs) : 0, 723
Remote Config [candidate] (716.335 µs) : 0, 716
Telemetry [baseline] (9.046 ms) : 0, 9046
Telemetry [candidate] (9.005 ms) : 0, 9005
Flare Poller [baseline] (3.88 ms) : 0, 3880
Flare Poller [candidate] (3.914 ms) : 0, 3914
IAST [baseline] (24.786 ms) : 0, 24786
IAST [candidate] (24.826 ms) : 0, 24826
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (790.307 ms) : 0, 790307
BytebuddyAgent [candidate] (795.294 ms) : 0, 795294
GlobalTracer [baseline] (256.095 ms) : 0, 256095
GlobalTracer [candidate] (257.79 ms) : 0, 257790
AppSec [baseline] (33.857 ms) : 0, 33857
AppSec [candidate] (34.758 ms) : 0, 34758
Debugger [baseline] (67.476 ms) : 0, 67476
Debugger [candidate] (66.129 ms) : 0, 66129
Remote Config [baseline] (597.277 µs) : 0, 597
Remote Config [candidate] (615.232 µs) : 0, 615
Telemetry [baseline] (8.374 ms) : 0, 8374
Telemetry [candidate] (8.495 ms) : 0, 8495
Flare Poller [baseline] (3.539 ms) : 0, 3539
Flare Poller [candidate] (3.519 ms) : 0, 3519
IAST [baseline] (27.169 ms) : 0, 27169
IAST [candidate] (27.265 ms) : 0, 27265
section profiling
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (702.701 ms) : 0, 702701
BytebuddyAgent [candidate] (700.122 ms) : 0, 700122
GlobalTracer [baseline] (221.55 ms) : 0, 221550
GlobalTracer [candidate] (220.422 ms) : 0, 220422
AppSec [baseline] (32.274 ms) : 0, 32274
AppSec [candidate] (32.074 ms) : 0, 32074
Debugger [baseline] (68.795 ms) : 0, 68795
Debugger [candidate] (68.061 ms) : 0, 68061
Remote Config [baseline] (656.142 µs) : 0, 656
Remote Config [candidate] (668.331 µs) : 0, 668
Telemetry [baseline] (9.001 ms) : 0, 9001
Telemetry [candidate] (8.94 ms) : 0, 8940
Flare Poller [baseline] (3.732 ms) : 0, 3732
Flare Poller [candidate] (3.898 ms) : 0, 3898
ProfilingAgent [baseline] (97.686 ms) : 0, 97686
ProfilingAgent [candidate] (96.86 ms) : 0, 96860
Profiling [baseline] (98.273 ms) : 0, 98273
Profiling [candidate] (97.43 ms) : 0, 97430
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section baseline
no_agent (1.167 ms) : 1156, 1178
. : milestone, 1167,
iast (3.178 ms) : 3141, 3214
. : milestone, 3178,
iast_FULL (5.91 ms) : 5849, 5970
. : milestone, 5910,
iast_GLOBAL (3.639 ms) : 3583, 3696
. : milestone, 3639,
profiling (1.916 ms) : 1900, 1932
. : milestone, 1916,
tracing (1.789 ms) : 1775, 1804
. : milestone, 1789,
section candidate
no_agent (1.163 ms) : 1152, 1174
. : milestone, 1163,
iast (3.287 ms) : 3249, 3325
. : milestone, 3287,
iast_FULL (5.836 ms) : 5777, 5894
. : milestone, 5836,
iast_GLOBAL (3.54 ms) : 3485, 3596
. : milestone, 3540,
profiling (2.015 ms) : 1997, 2032
. : milestone, 2015,
tracing (1.799 ms) : 1784, 1813
. : milestone, 1799,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section baseline
no_agent (19.021 ms) : 18824, 19218
. : milestone, 19021,
appsec (18.582 ms) : 18392, 18771
. : milestone, 18582,
code_origins (17.734 ms) : 17559, 17910
. : milestone, 17734,
iast (17.489 ms) : 17316, 17663
. : milestone, 17489,
profiling (19.35 ms) : 19156, 19543
. : milestone, 19350,
tracing (17.559 ms) : 17384, 17734
. : milestone, 17559,
section candidate
no_agent (18.938 ms) : 18746, 19131
. : milestone, 18938,
appsec (18.352 ms) : 18161, 18544
. : milestone, 18352,
code_origins (17.881 ms) : 17705, 18057
. : milestone, 17881,
iast (17.984 ms) : 17802, 18167
. : milestone, 17984,
profiling (18.888 ms) : 18701, 19075
. : milestone, 18888,
tracing (17.908 ms) : 17728, 18088
. : milestone, 17908,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section baseline
no_agent (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
appsec (14.478 s) : 14478000, 14478000
. : milestone, 14478000,
iast (18.118 s) : 18118000, 18118000
. : milestone, 18118000,
iast_GLOBAL (18.306 s) : 18306000, 18306000
. : milestone, 18306000,
profiling (14.715 s) : 14715000, 14715000
. : milestone, 14715000,
tracing (14.623 s) : 14623000, 14623000
. : milestone, 14623000,
section candidate
no_agent (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
appsec (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
iast (18.192 s) : 18192000, 18192000
. : milestone, 18192000,
iast_GLOBAL (17.82 s) : 17820000, 17820000
. : milestone, 17820000,
profiling (14.694 s) : 14694000, 14694000
. : milestone, 14694000,
tracing (14.685 s) : 14685000, 14685000
. : milestone, 14685000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~233d1aeba7, baseline=1.57.0-SNAPSHOT~3101a85cf1
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.639 ms) : 3424, 3854
. : milestone, 3639,
iast (2.202 ms) : 2138, 2266
. : milestone, 2202,
iast_GLOBAL (2.245 ms) : 2181, 2310
. : milestone, 2245,
profiling (2.064 ms) : 2012, 2116
. : milestone, 2064,
tracing (2.032 ms) : 1982, 2083
. : milestone, 2032,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.658 ms) : 3444, 3872
. : milestone, 3658,
iast (2.2 ms) : 2136, 2264
. : milestone, 2200,
iast_GLOBAL (2.25 ms) : 2185, 2314
. : milestone, 2250,
profiling (2.074 ms) : 2020, 2127
. : milestone, 2074,
tracing (2.036 ms) : 1986, 2086
. : milestone, 2036,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. It could be nice to link the public doc update if there is one!
❔ question: I don't have the OTel Logs API RFC support in mind but I just wanted to quickly confirm that it will fit nicely with their related config too?
there's no equivalent OTel config wrt. the tracer's own logging |
|
Public doc: DataDog/documentation#33464 |
What Does This Do
Adds support for
DD_LOG_FORMAT_JSONenvironment variableMotivation
Easier to configure across a fleet of services compared to adding
-Ddatadog.slf4j.simpleLogger.jsonEnabled=trueto each JVM command-line (see #10047)Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]