feat: add PartialEq and Eq traits to TracerMetadata#1922
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
duncanpharvey
requested review from
a team and
Lewis-E
and removed request for
a team
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
apiarian-datadog
approved these changes
Apr 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
=======================================
Coverage 71.73% 71.74%
=======================================
Files 434 434
Lines 69951 69967 +16
=======================================
+ Hits 50182 50200 +18
+ Misses 19769 19767 -2
🚀 New features to boost your workflow:
|
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 9aaa002 | Docs | Datadog PR Page | Give us feedback! |
mabdinur
approved these changes
Apr 24, 2026
Lewis-E
approved these changes
Apr 27, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
duncan-harvey/tracer-metadata-equality-traits
branch
This was referenced Apr 27, 2026
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
Apr 29, 2026
# What does this PR do? Derives Hash on TracerMetadata, allowing instances to be used as keys in hash-based collections such as HashMap and HashSet. # Motivation Needed for DataDog/serverless-components#51 (comment) # Additional Notes Follows [feat: add PartialEq and Eq traits to TracerMetadata](#1922). # How to test the change? Unit tests. Co-authored-by: duncan.harvey <duncan.harvey@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Derives PartialEq and Eq on TracerMetadata, enabling equality comparisons between instances using
==and!=.Motivation
Adding these standard library traits enables equality assertions without requiring callers to implement their own field by field comparison. Needed for DataDog/serverless-components#51 (comment)
Additional Notes
How to test the change?
Unit tests