Tag the run span with the raw command and effective interp options - #603
Draft
julesmcrt wants to merge 1 commit into
Draft
Tag the run span with the raw command and effective interp options#603julesmcrt wants to merge 1 commit into
julesmcrt wants to merge 1 commit into
Conversation
…ions Adds rshell.run.command (the full script text, via a new Script RunnerOption) and rshell.run.options.* tags (mode, max_execution_time, proc_path, host_prefix, allowed_paths, allow_all_commands, allowed_commands, allowed_system_services, systemd_target_configured) to the top-level "run" telemetry span, so a trace fully describes what was executed and under which policy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interp.Script(text string) RunnerOptionto attach the raw, unparsed script/command string to aRunner, and tag it on the top-levelruntelemetry span asrshell.run.command.RunnerOptionconfiguration on the same span asrshell.run.options.*:mode,max_execution_time,proc_path,host_prefix,allowed_paths(aspath:ro/path:rw),allow_all_commands,allowed_commands,allowed_system_services, andsystemd_target_configured.cmd/rshell/main.goto pass the raw script text throughinterp.Scriptso the CLI's telemetry includes it.Note: the full raw script text is tagged verbatim, so any secrets embedded in a script will flow into telemetry unredacted. This is an intentional, explicitly-requested tradeoff — see the design decisions in AGENTS.md around process/argv privacy for context on why this is called out.
Test plan
make fmtgo build ./...go vet ./...go test ./interp/... ./cmd/...(addedTestRunSpanCommandAndOptionsininterp/tracing_test.go)🤖 Generated with Claude Code