Skip to content

make pulling images faster by removing files more efficiently #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbeauchesne merged 9 commits into from
May 6, 2026
Merged

make pulling images faster by removing files more efficiently #6809

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
421cebd
make pulling images faster by removing need for file removal
rochdev Apr 24, 2026
536ea6f
inline code instead of using external action
rochdev Apr 29, 2026
981f499
reformat
rochdev Apr 29, 2026
9ca75a7
fix lint
rochdev Apr 29, 2026
08d87dc
move the logic before any checkout
rochdev Apr 29, 2026
93840e4
remove resize
rochdev Apr 29, 2026
00e18ab
add removal of android system images
rochdev Apr 29, 2026
5052be4
switch to a better action without lvm hacks
rochdev Apr 29, 2026
93e8037
use sha
rochdev Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/actions/pull_images/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ inputs:
runs:
using: composite
steps:
- name: Free Disk Space
uses: endersonmenezes/free-disk-space@7901478139cff6e9d44df5972fd8ab8fcade4db1 # v3.2.2
with:
remove_android: false # Takes a long time to remove even with rmz
remove_dotnet: true # Pretty quick and saves a lot
remove_haskell: true # Extremely quick and saves a lot
remove_tool_cache: false # Decent savings but not fast enough
remove_packages: false # By far the slowest option
remove_packages_one_command: true
remove_folders: "/usr/share/swift /usr/share/az* /usr/local/share/chromium"

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid wildcard path in remove_folders configuration

remove_folders includes /usr/share/az*, but this action passes each folder argument quoted (run_rm -f "${FOLDER}" in the pinned endersonmenezes/free-disk-space script), so globbing does not occur and the literal * path is not removed. On runners where Azure directories are present, this silently reclaims less space than expected and can leave docker compose pull vulnerable to running out of disk.

Useful? React with 👍 / 👎.

@rochdev rochdev May 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was straight from the documentation of the action itself.

rm_cmd: "rmz" # Use 'rmz' for faster deletion (default: 'rm')
rmz_version: "3.1.1" # Required when rm_cmd is 'rmz'
- name: Get image list
shell: bash
run: |
Expand All @@ -37,10 +49,6 @@ runs:
username: ${{ inputs.dockerhub_username }}
password: ${{ inputs.dockerhub_token }}

- name: clean-up
shell: bash
run: sudo rm -rf /usr/local/lib/android

#retry
- name: Pull
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
Expand All @@ -50,7 +58,3 @@ runs:
timeout_minutes: 15
retry_wait_seconds: 10
max_attempts: 3

- name: Disk space usage
shell: bash
run: df -h
Loading