Skip to content

add option to skip removing android#6826

Closed
rochdev wants to merge 1 commit intomainfrom
rochdev/remove-android-option
Closed

add option to skip removing android#6826
rochdev wants to merge 1 commit intomainfrom
rochdev/remove-android-option

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Apr 28, 2026

Motivation

I tried implementing an alternative clean up strategy in #6809, but it ended up being more contentious than anticipated. This PR instead simply adds an option to skip the removal instead so that we can experiment with alternative approaches only in dd-trace-js. We can then port those back to system tests once we have gained enough confidence.

Changes

Add option to skip removing android.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@rochdev rochdev requested a review from a team as a code owner April 28, 2026 17:46
@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/actions/pull_images/action.yml                                  @DataDog/system-tests-core
.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
.github/workflows/system-tests.yml                                      @DataDog/system-tests-core

@rochdev rochdev marked this pull request as draft April 28, 2026 23:49
@rochdev
Copy link
Copy Markdown
Member Author

rochdev commented Apr 28, 2026

Turns out the follow up to add a way to do a custom cleanup first is not so easy. I'll re-explore the previous option but only using what makes sense for us.

@rochdev rochdev closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant