Draft
Conversation
…te injection Phase 2 — OTLP trace metrics export: tests/otel/test_otlp_trace_metrics.py validates that all four dd.trace.span.* metrics appear on /v1/metrics when DD_TRACE_OTEL_METRICS_ENABLED=true (new APM_TRACING_OTLP_METRICS scenario). Phase 3 — W3C TraceState ot.th injection: tests/parametric/test_tracestate_ot_th.py validates that an ot=th:<hex> vendor entry is present in the outgoing tracestate for sampled spans. Supporting changes: - Add apm_tracing_otlp_metrics scenario (scenarios/__init__.py) - Add get_otel_metrics() to OpenTelemetryInterfaceValidator (interfaces) - Add otlp_trace_metrics and w3c_tracestate_ot_probability_threshold features - Mark both tests as missing_feature in manifests/nodejs.yml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTLP trace metrics export:
tests/otel/test_otlp_trace_metrics.py validates that all four
dd.trace.span.* metrics appear on /v1/metrics when
DD_TRACE_OTEL_METRICS_ENABLED=true (new APM_TRACING_OTLP_METRICS scenario).
W3C TraceState ot.th injection:
tests/parametric/test_tracestate_ot_th.py validates that an ot=th:
vendor entry is present in the outgoing tracestate for sampled spans.
Supporting changes:
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present