Skip to content

feat: upgrade to Pest v4 and implement testing improvements#23

Open
KilianTrunk wants to merge 17 commits intoDataLinx:mainfrom
KilianTrunk:feat/pest-v4-upgrade-and-testing-improvements
Open

feat: upgrade to Pest v4 and implement testing improvements#23
KilianTrunk wants to merge 17 commits intoDataLinx:mainfrom
KilianTrunk:feat/pest-v4-upgrade-and-testing-improvements

Conversation

@KilianTrunk
Copy link
Copy Markdown
Contributor

No description provided.

@KilianTrunk KilianTrunk marked this pull request as draft October 22, 2025 08:00
@KilianTrunk KilianTrunk force-pushed the feat/pest-v4-upgrade-and-testing-improvements branch from 338003e to cd730e8 Compare October 22, 2025 10:51
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.54%. Comparing base (b14a838) to head (2872da6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #23      +/-   ##
============================================
- Coverage     83.27%   82.54%   -0.73%     
  Complexity      255      255              
============================================
  Files            30       30              
  Lines          1351     1358       +7     
============================================
- Hits           1125     1121       -4     
- Misses          226      237      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KilianTrunk KilianTrunk marked this pull request as ready for review October 22, 2025 12:10
@KilianTrunk
Copy link
Copy Markdown
Contributor Author

KilianTrunk commented Oct 22, 2025

@SlimDeluxe check the test names - sharding should be self-explanatory, but its basically splitting up tests into batches

@SlimDeluxe
Copy link
Copy Markdown
Member

@KilianTrunk broski, do you remember if you had to install the sockets PHP extension?
I am getting this error locally in the Lando container:

{11:23}/app:fork/KilianTrunk/feat/pest-v4-upgrade-and-testing-improvements ✗ ➭ composer update      
Xdebug: [Log Files] File '/tmp/xdebug.log' could not be opened.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires pestphp/pest-plugin-browser ^4.0 -> satisfiable by pestphp/pest-plugin-browser[v4.0.0, ..., 4.x-dev].
    - pestphp/pest-plugin-browser[v4.0.0, ..., 4.x-dev] require ext-sockets * -> it is missing from your system. Install or enable PHP's sockets extension.

Maybe you ran it on your local PHP and not in the Lando container?

Also, why was the pcntl extension necessary in CI tests?

@KilianTrunk
Copy link
Copy Markdown
Contributor Author

@SlimDeluxe heyo!

pestphp/pest-plugin-browser:^4 hard-requires ext-sockets, so if your Lando slimdeluxe/php:* image doesn’t have sockets enabled you’ll get exactly that Composer error.

I think I ran the update with a PHP runtime that already had sockets (so it didn’t blow up), but inside the Lando container it needs to be installed/enabled.

And regarding pcntl, CI runs Pest with --parallel (plus sharding), so pcntl is needed for the forked/parallel test processes. If we drop --parallel, we can drop pcntl too I believe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants