feat: upgrade to Pest v4 and implement testing improvements#23
feat: upgrade to Pest v4 and implement testing improvements#23KilianTrunk wants to merge 17 commits intoDataLinx:mainfrom
Conversation
338003e to
cd730e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
============================================
- Coverage 83.27% 82.54% -0.73%
Complexity 255 255
============================================
Files 30 30
Lines 1351 1358 +7
============================================
- Hits 1125 1121 -4
- Misses 226 237 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@SlimDeluxe check the test names - sharding should be self-explanatory, but its basically splitting up tests into batches |
|
@KilianTrunk broski, do you remember if you had to install the sockets PHP extension? Maybe you ran it on your local PHP and not in the Lando container? Also, why was the pcntl extension necessary in CI tests? |
|
@SlimDeluxe heyo! pestphp/pest-plugin-browser:^4 hard-requires ext-sockets, so if your Lando slimdeluxe/php:* image doesn’t have sockets enabled you’ll get exactly that Composer error. I think I ran the update with a PHP runtime that already had sockets (so it didn’t blow up), but inside the Lando container it needs to be installed/enabled. And regarding pcntl, CI runs Pest with --parallel (plus sharding), so pcntl is needed for the forked/parallel test processes. If we drop --parallel, we can drop pcntl too I believe? |
No description provided.