Prototype changes to use semaphore signalling for Unix#126
Open
karlmcdowall wants to merge 1 commit into
Open
Conversation
Very much in the quick-prototype phase. Demonstrate that the CTRL-C logic can be alternatively implemented using a unnamed POSIX semaphore to signal between signal-handler and blocking thread.
|
FWIW I think this can be closed? July 2025 PR that implemented similar was merged (Sep 2025):
That switch to semaphore usage with the
I think you meant to link to your issue here: #125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE DON'T MERGE!
Code is very much in the quick-prototype phase and very much not ready to be merged. Code is posted to demonstrate that the CTRL-C logic can be implemented using an unnamed POSIX semaphore to signal between signal-handler and blocking thread on unix rather than a pipe.
I've started a thread with the background on this here.