fix(daemon): preserve disabled UI on manual start - #2205
Open
vincentkoc wants to merge 1 commit into
Open
vincentkoc wants to merge 1 commit into
vincentkoc wants to merge 1 commit into
Conversation
Signed-off-by: Vincent Koc <25068+vincentkoc@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
vincentkoc
marked this pull request as ready for review
September 14, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A cold
daemon startnow preserves a savedui_enabled=falsesetting. Previously it unconditionally requested UI configuration, rewrote the preference totrue, and started the HTTP listener.An explicit cold
--portor--openrequest keeps its existing UI-enabling behavior. Repeated bare starts report the disabled UI without incorrectly saying a browser request failed, and the configuration hint points toconfig set ui_enabled true. The configuration docs describe these semantics.Fixes #2114
Validation
scripts/test.sh BUILD_DIR=build/full-testspassed on macOS arm64: 8,022 tests passed, 10 platform skips, plus all prescribed process guards and security/ordering checks.git diff --check, formatting, cppcheck, and the NOLINT suppression check passed.scripts/lint.shexited 2 with 6,972 repo-wide clang-tidy diagnostics. An exact-path VFS comparison of unchanged and candidatesrc/main.cproduced 125 diagnostics each with the same diagnostic categories; none point to changed lines. The existingmain_run_daemon_ctlcognitive-complexity diagnostic increases from 82 to 89, already above the threshold of 25. Tools: Apple clang-format 21, clang-tidy 22.1.8, cppcheck 2.21.0.Checklist
git commit -s).