chore: resolve open dependabot security alerts - #309
Merged
Conversation
- golang.org/x/crypto v0.45.0 -> v0.54.0 (critical/high/medium, alerts #24-#36) - golang.org/x/net v0.47.0 -> v0.57.0 (medium, alert #23) - go directive 1.24.0 -> 1.25.0 (required by x/crypto v0.54.0) - golangci-lint-action v4 -> v8 (golangci-lint v2 required for Go 1.25) - add .golangci.yml to suppress pre-existing style checks, fix ST1005 and errcheck issues
There was a problem hiding this comment.
Pull request overview
This PR focuses on resolving Dependabot security alerts by bumping vulnerable golang.org/x/* modules, updating the repo’s Go toolchain target, and adjusting CI linting configuration to accommodate the newer Go/golangci-lint versions.
Changes:
- Bumped
golang.org/x/cryptoandgolang.org/x/net(and related indirect deps) to patched versions; updatedgodirective to1.25.0. - Updated GitHub Actions lint workflow to
golangci/golangci-lint-action@v8and added a.golangci.ymlconfig. - Addressed newly surfaced linter findings by adjusting a few error strings and ignoring
Close()return values in examples/tests.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
request.go |
Tweaks an error string when request body encoding results in an empty buffer. |
configmanager.go |
Refactors an error format string for unexpected HTTP status codes. |
bucketing/model_filters.go |
Removes trailing newlines from several fmt.Errorf messages. |
client.go |
Normalizes an error message string casing (Nil → nil). |
event_manager.go |
Removes trailing punctuation from an error string. |
example/hooks/main.go |
Avoids errcheck failure by explicitly ignoring Close()’s error. |
config_metadata_test.go |
Suppresses errcheck on defer client.Close() in tests. |
go.mod |
Bumps go directive and updates indirect golang.org/x/* dependency versions. |
go.sum |
Updates module checksums for bumped dependencies. |
.golangci.yml |
Adds golangci-lint configuration to suppress pre-existing staticcheck/style findings. |
.github/workflows/lint.yml |
Updates golangci-lint GitHub Action from v4 to v8. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
55
to
57
| if bodyBuf.Len() == 0 { | ||
| err = fmt.Errorf("invalid body type %s\n", contentType) | ||
| err = fmt.Errorf("invalid body type %s", contentType) | ||
| return nil, err |
Comment on lines
+321
to
322
| err = fmt.Errorf("unexpected response code: %d\nBody: %s\nURL: %s\nHeaders: %s\nCould not download configuration. Using cached version if available %s", | ||
| resp.StatusCode, resp.Body, e.getConfigURL(), resp.Header, resp.Header.Get("ETag")) |
JamieSinn
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot Alerts Resolved
golang.org/x/cryptogolang.org/x/netAdditional changes
godirective bumped 1.24.0 → 1.25.0 (required byx/cryptov0.54.0)golangci-lint-actionv4 → v8 (golangci-lint v2 required for Go 1.25 support).golangci.ymlto suppress pre-existing style issues newly flagged by golangci-lint v2 (ST1003, ST1016, ST1020/21/22 — naming conventions and comment format on public API that predate this PR)ST1005anderrcheckissues surfaced by the updated linter