Skip to content

chore: use --exact versions with lerna - #1116

Merged
jonathannorris merged 2 commits into
mainfrom
chore-use-lerna-exact
Jul 16, 2025
Merged

chore: use --exact versions with lerna#1116
jonathannorris merged 2 commits into
mainfrom
chore-use-lerna-exact

Conversation

@jonathannorris

@jonathannorris jonathannorris commented Jul 16, 2025

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Jul 16, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 9:07pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 9:07pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
js-sdks-next-js-page-router ⬜️ Ignored (Inspect) Jul 16, 2025 9:07pm

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches internal DevCycle dependencies to exact versions, bumps related OpenFeature packages to newer versions, and updates Lerna commands to use the --exact flag.

  • Pinned @devcycle/* dependencies in SDK package.json files to exact versions instead of caret ranges
  • Updated several OpenFeature peerDependencies (@openfeature/web-sdk, @openfeature/core, @openfeature/server-sdk) to their latest minor versions
  • Added --exact to yarn lerna version commands in release scripts

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/react/package.json Pinned DevCycle dependencies to exact versions
sdk/react-native/package.json Pinned DevCycle dependencies to exact versions
sdk/react-native-expo/package.json Pinned DevCycle dependencies to exact versions
sdk/openfeature-web-provider/package.json Pinned DevCycle dependency; bumped @openfeature/web-sdk peerDependency
sdk/openfeature-react-provider/package.json Pinned DevCycle dependencies; bumped @openfeature/web-sdk peerDependency
sdk/openfeature-nestjs-provider/package.json Pinned Node.js server SDK dependency
sdk/openfeature-angular-provider/package.json Pinned DevCycle dependencies; bumped @openfeature/web-sdk peerDependency
sdk/nodejs/package.json Pinned DevCycle and OpenFeature dependencies to exact/tildes
sdk/nextjs/package.json Pinned DevCycle dependencies to exact versions
sdk/nestjs/package.json Pinned DevCycle dependencies to exact versions
sdk/js/package.json Pinned DevCycle types dependency to exact version
sdk/js-cloud-server/package.json Pinned DevCycle types dependency to exact version
scripts/lerna-version.sh Added --exact flag to Lerna versioning command
scripts/lerna-version-ci.sh Added --exact flag to Lerna versioning command in CI script
Comments suppressed due to low confidence (3)

scripts/lerna-version.sh:62

  • [nitpick] Consider adding a brief comment explaining why the --exact flag is now required, so future maintainers understand the strict versioning policy.
yarn lerna version --exact --force-publish=$PACKAGES --message "chore(release): publish" "$@" --no-push

sdk/openfeature-web-provider/package.json:26

  • [nitpick] Review whether peerDependencies should follow the same exact-version policy for consistency, or document the reason for keeping a caret range here.
        "@openfeature/web-sdk": "^1.5.0"

sdk/react/package.json:30

  • After pinning dependency versions, ensure that the lockfile is regenerated (e.g., run npm install or yarn install) so it stays in sync with these changes.
        "@devcycle/js-client-sdk": "1.45.1",

@jonathannorris
jonathannorris enabled auto-merge (squash) July 16, 2025 21:07
@jonathannorris
jonathannorris merged commit a7cf5c7 into main Jul 16, 2025
21 checks passed
@jonathannorris
jonathannorris deleted the chore-use-lerna-exact branch July 16, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants