fix: add eval reasons to aggregate events - #1121
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
phaym
reviewed
Jul 22, 2025
phaym
approved these changes
Jul 22, 2025
phaym
left a comment
phaym
left a comment
Contributor
There was a problem hiding this comment.
lgtm but we prob want someone more familiar to take a look
phaym
reviewed
Jul 22, 2025
…include eventEvalReasons
kaushalkapasi
force-pushed
the
fix-add-eval-reasons-to-aggregate-events
branch
from
July 22, 2025 19:46
e90e826 to
ff1535e
Compare
JamieSinn
reviewed
Jul 23, 2025
JamieSinn
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eventsEvalReasonas a test-harness capability to verify eval reasons are properly generated & sent in the events payload