fix(client): ReferenceError: Property 'document' doesn't exist on react native - #1131
Closed
santiagofm wants to merge 1 commit into
Closed
fix(client): ReferenceError: Property 'document' doesn't exist on react native#1131santiagofm wants to merge 1 commit into
santiagofm wants to merge 1 commit into
Conversation
|
@santiagofm is attempting to deploy a commit to the DevCycle Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hey @santiagofm thanks for opening this PR, I've made an internal PR with the same change so that all the tests can run due to our security requirements. We should have this fix merged & released shortly! |
Contributor
|
Hey @santiagofm, we've release this fix as part of React-Native SDK v1.22.1. Thanks for submitting this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
@devcycle/react-client-sdkwe keep getting a reference error because the globaldocumentobject doesn't exist on react-native.Seems like we are guarding against this when registering the visibility changed handlers, but not when closing the client and unregistering.