DataGrid - TextArea editor should have the aria-invalid attribute when invalid (T1296376)#32801
Open
markallenramirez wants to merge 12 commits intoDevExpress:26_1from
Open
DataGrid - TextArea editor should have the aria-invalid attribute when invalid (T1296376)#32801markallenramirez wants to merge 12 commits intoDevExpress:26_1from
markallenramirez wants to merge 12 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an accessibility bug (T1296376) where a DataGrid cell using a dxTextArea editor did not receive the aria-invalid attribute when its value failed validation. The fix works by extending the EDITORS_INPUT_SELECTOR in const.ts to also match <textarea> elements, enabling the existing validation-aria-attribute logic in m_validating.ts to find and annotate the textarea.
Changes:
- Extends
EDITORS_INPUT_SELECTORinconst.tsto includetextarea:not([hidden])alongside the existinginput:not([type='hidden']). - Adds a TestCafe E2E test in
bugs.tsthat verifies thearia-invalidattribute is set on adxTextAreaeditor after a required-field validation failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/editing/const.ts |
Extends EDITORS_INPUT_SELECTOR to include textarea elements (excluding those with the HTML hidden attribute) |
e2e/testcafe-devextreme/tests/dataGrid/common/accessibility/bugs.ts |
Adds a new TestCafe test verifying aria-invalid="true" is set on the dxTextArea editor after validation failure |
packages/devextreme/js/__internal/grids/grid_core/editing/const.ts
Outdated
Show resolved
Hide resolved
e2e/testcafe-devextreme/tests/dataGrid/common/accessibility/bugs.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/editing/const.ts
Outdated
Show resolved
Hide resolved
markallenramirez
force-pushed
the
bug_T1296376/26_1
branch
from
485f61a to
d5e76c2
Compare
Raushen
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.