chore(devextreme): replace gulp js-bundles-prod with nx bundle executor#32806
Open
chaosmirage wants to merge 2 commits into26_1from
Open
chore(devextreme): replace gulp js-bundles-prod with nx bundle executor#32806chaosmirage wants to merge 2 commits into26_1from
chaosmirage wants to merge 2 commits into26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates DevExtreme’s production JS bundle step away from the Gulp js-bundles-prod task to the devextreme-nx-infra-plugin:bundle Nx executor, aligning bundling with the monorepo’s Nx-based build pipeline.
Changes:
- Adjusts the Nx bundle executor’s webpack config assembly (
createWebpackConfig). - Reworks
packages/devextremeNx targets to build prod bundles viabundle:prod:buildand apply license headers via a unifiedbundle:headerstarget (with aprodconfiguration). - Updates
bundle:prodto run Nx commands instead ofgulp js-bundles-prod.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/nx-infra-plugin/src/executors/bundle/executor.ts | Changes webpack optimization handling for bundles produced by the Nx executor. |
| packages/devextreme/project.json | Replaces the Gulp prod bundling command with Nx bundle + license-header steps; refactors header target naming/configurations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.