Skip to content

Scheduler: describe getOccurrences + Occurence API#8529

Open
vladaskorohodova wants to merge 5 commits intoDevExpress:26_1from
vladaskorohodova:scheduler-get-occurrences26_1
Open

Scheduler: describe getOccurrences + Occurence API#8529
vladaskorohodova wants to merge 5 commits intoDevExpress:26_1from
vladaskorohodova:scheduler-get-occurrences26_1

Conversation

@vladaskorohodova
Copy link
Collaborator

No description provided.

@vladaskorohodova vladaskorohodova self-assigned this Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 10:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Copilot AI review requested due to automatic review settings March 6, 2026 11:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Co-authored-by: Vladimir Abadzhev <vladimira@devexpress.com>
Copilot AI review requested due to automatic review settings March 11, 2026 06:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

---
##### shortDescription
<!-- Description goes here -->
The start date of the appointment occurrence.
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shortDescription sections in this docs set typically keep the content indented under the heading (the placeholder line you replaced was indented). To avoid breaking the doc generator’s parsing/formatting, keep the same indentation level used by the placeholder. Apply the same formatting fix to endDate.md, appointmentData.md, and Occurrence.md shortDescription blocks as well.

Suggested change
The start date of the appointment occurrence.
The start date of the appointment occurrence.

Copilot uses AI. Check for mistakes.
Comment on lines +28 to +30
startDate: new Date(2026, 1, 1, 9, 0),
endDate: new Date(2026, 1, 6, 10, 0),
recurrenceRule: 'FREQ=DAILY;COUNT=5'
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example’s dates/durations don’t match the comment: (1) the recurring "Meeting" has a ~5-day duration (endDate is Feb 6 while startDate is Feb 1), which will produce multi-day overlapping occurrences rather than a 1-hour meeting; (2) new Date(2026, 1, 4) is Feb 4 at 00:00, so an occurrence on Feb 4 at 09:00 would likely be excluded—making “February 2–4” inaccurate. Adjust the meeting endDate to preserve the intended appointment duration (e.g., same day 10:00), and either change the interval end to include Feb 4’s occurrences (e.g., Feb 5 00:00 / end-of-day) or update the comment to reflect the actual returned range.

Copilot uses AI. Check for mistakes.
Comment on lines +39 to +40
// Returns occurrences of the "Meeting" appointment for February 2-4, 2026 and the "Call" appointment for February 3, 2026:
const occurrences = scheduler.getOccurrences(new Date(2026, 1, 2), new Date(2026, 1, 4), appointments);
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example’s dates/durations don’t match the comment: (1) the recurring "Meeting" has a ~5-day duration (endDate is Feb 6 while startDate is Feb 1), which will produce multi-day overlapping occurrences rather than a 1-hour meeting; (2) new Date(2026, 1, 4) is Feb 4 at 00:00, so an occurrence on Feb 4 at 09:00 would likely be excluded—making “February 2–4” inaccurate. Adjust the meeting endDate to preserve the intended appointment duration (e.g., same day 10:00), and either change the interval end to include Feb 4’s occurrences (e.g., Feb 5 00:00 / end-of-day) or update the comment to reflect the actual returned range.

Copilot uses AI. Check for mistakes.

##### param(startDate): Date
<!-- Description goes here -->
The start date of the time interval.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The start date of the time interval.
The start date of the interval.


##### param(endDate): Date
<!-- Description goes here -->
The end date of the time interval.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The end date of the time interval.
The end date of the interval.

---
##### shortDescription
<!-- Description goes here -->
Gets an array of appointment occurrences that fall within a specified time interval.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Gets an array of appointment occurrences that fall within a specified time interval.
Gets an array of appointment occurrences that fall within a specified interval.


---
<!-- Description goes here --> No newline at end of file
An occurrence is an appointment instance that falls within the specified time interval. Recurring appointments can generate multiple occurrences.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An occurrence is an appointment instance that falls within the specified time interval. Recurring appointments can generate multiple occurrences.
An occurrence is an appointment instance that falls within the specified interval. Recurring appointments can generate multiple occurrences.


---
<!-- Description goes here --> No newline at end of file
An occurrence is an appointment instance that falls within the specified time interval. Recurring appointments can generate multiple occurrences. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An occurrence is an appointment instance that falls within the specified time interval. Recurring appointments can generate multiple occurrences.
An occurrence is an appointment instance that falls within the specified interval. Recurring appointments can generate multiple occurrences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants