feat(egfx): add send_uncompressed_frame for V8 clients#1182
Open
Greg Lamberson (glamberson) wants to merge 1 commit intoDevolutions:masterfrom
Open
feat(egfx): add send_uncompressed_frame for V8 clients#1182Greg Lamberson (glamberson) wants to merge 1 commit intoDevolutions:masterfrom
Greg Lamberson (glamberson) wants to merge 1 commit intoDevolutions:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands server-side capabilities in two areas: EGFX frame sending for clients that don’t support H.264, and connection-time credential validation during the acceptor sequence.
Changes:
- Add
GraphicsPipelineServer::send_uncompressed_frame()to send raw pixels viaWireToSurface1withCodec1Type::Uncompressed. - Add a new
CredentialValidatortrait and plumb it intoRdpServerto optionally validate client-provided credentials during connection setup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| crates/ironrdp-egfx/src/server.rs | Adds a new public API to queue an EGFX uncompressed frame via the StartFrame/WireToSurface1/EndFrame sequence. |
| crates/ironrdp-server/src/server.rs | Introduces an optional credential validation hook and applies it during client_accepted. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greg Lamberson (glamberson)
force-pushed
the
feat/egfx-send-uncompressed-frame
branch
from
5a303b8 to
9279ade
Compare
Add a method to GraphicsPipelineServer that sends raw pixel data through WireToSurface1 with Codec1Type::Uncompressed. This enables EGFX frame delivery to V8 clients that support the graphics pipeline but not H.264 (AVC420/AVC444). Follows the same pattern as send_avc420_frame and send_avc444_frame: readiness check, backpressure check, surface lookup, StartFrame + WireToSurface1 + EndFrame sequence. Without this method, servers have no API to send EGFX frames to V8 clients and must fall back to legacy FastPath bitmap delivery, losing EGFX benefits (surface management, frame acknowledgment, QoE metrics).
Greg Lamberson (glamberson)
force-pushed
the
feat/egfx-send-uncompressed-frame
branch
from
9279ade to
30d0a38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
send_uncompressed_frame()toGraphicsPipelineServerfor sending raw pixel data throughWireToSurface1withCodec1Type::Uncompressed.V8 clients support the EGFX graphics pipeline but not H.264 (AVC420/AVC444). Currently there's no server API to send EGFX frames to these clients. Without this, servers must fall back to legacy FastPath bitmap delivery, losing EGFX benefits: surface management, frame acknowledgment, QoE metrics, and ZGFX compression.
Follows the same pattern as
send_avc420_frameandsend_avc444_frame: readiness check, backpressure check, surface lookup, then the StartFrame + WireToSurface1 + EndFrame sequence.Changes:
crates/ironrdp-egfx/src/server.rssend_uncompressed_frame()All xtask checks pass (fmt, lints, tests).