Feat/sc 004 verification engine - #316
Open
akinboyewaSamson wants to merge 4 commits into
Open
Conversation
Author
|
Kindly review pr |
Author
|
kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #284
This PR transitions the core TruthBounty verification logic fully on-chain as outlined in SC-004, removing reliance on centralized backend processes. A new Hardhat environment was initialized within the contracts/ directory to house this protocol infrastructure.
🎯 Key Implementations
VerificationEngine Contract: Created deterministic, on-chain recording of TRUE / FALSE claim verifications.
Duplicate Prevention: Implemented O(1) mapping lookups to enforce one-verification-per-wallet.
Eligibility Validation: Verifications dynamically check registry states via IClaimRegistry to ensure claims are actively under verification.
Stake Locking: Securely utilizes SafeERC20 to lock verifier stake synchronously with submission.
Retrieval Methods: Exposed optimized view functions (getVerification, getClaimVerifications, getVerifierStake) for downstream aggregation/indexers.
Gas Benchmarks & Testing: 100% test coverage achieving fast execution (first verification: ~393k gas, subsequent: ~342k gas). Documented in docs/SC_004_BENCHMARKS.md.
📝 Files Added
contracts/src/VerificationEngine.sol
contracts/src/IClaimRegistry.sol
contracts/test/VerificationEngine.test.js
contracts/docs/SC_004_BENCHMARKS.md