Repository navigation
fix(image-translation): send image bytes directly to Tencent - #2725
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tencent image translation can reject remote-image URL requests with
InvalidParameter: Data: is requiredin both Pro and Lite. Send the existing locally prepared image as Base64Dataon the first request, preserving validation/compression, size limits, signing, throttling, and provider diagnostics.Add a Pro/Lite regression that requires prepared image bytes in a single request, and update recovery fixtures to verify that the source image is downloaded only once.
Validation:
ImageTranslationAdaptersTest,ImageTranslationDiagnosticsTest, andImageTranslationRecoveryTest.git diff --checkpassed for the three changed files.commonMainktlint reports existing violations in unchanged files.