Repository navigation
fix(weibo): support live photo playback - #2726
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weibo
livephotopictures were rendered as still images. Map entries with a nonblankvideoSrcto existing video media, preserving the original playback URL, thumbnail, dimensions, and account proxy; missing or blank URLs keep the image fallback.All new fixtures are synthetic and use
.example.testURLs. They cover mixed media and reposts, redirect/signed URL preservation, avoiding duplicates fromlive_photo, and missing or blank video URLs. Includes one formatting-only argument split produced by ktlint.Validation:
:social:vvo:jvmTest— 47 tests passed; the new playback regression failed before the mapper change.:social:vvo:ktlintFormat,:social:vvo:ktlintCheck, andgit diff --checkpassed.This uses existing video viewing/download behavior. Native app/device playback and native Live Photo album export remain outside this validation.
Refs #2684.