Repository navigation
Upgrade to Dioxus 0.8.0-alpha.3 and sync dioxus-native(-dom) from the Dioxus repo - #1260
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This was referenced Oct 23, 2026
staging-devin-ai-integration
Bot
force-pushed
the
devin/1792776194-dioxus-0.8
branch
from
October 23, 2026 19:27
91a20f0 to
286edea
Compare
… Dioxus repo Pins move from 0.7.3 to 0.8.0-alpha.3. The Dioxus copies of dioxus-native and dioxus-native-dom are copied over verbatim (except the package versions and the StyleThreading::Parallel setting), which brings the stack-machine WriteMutations (StackWriter + BlitzBackend), the MutationBuffer that defers applying mutations until the vdom has run, the html/NamedKey prelude re-exports, and removes the keyboard-types 0.7 compat module and the unused rustc-hash dependency.
Named keys are Key::Named(NamedKey::..). #[store] methods now carry their own visibility, so the cross-module ones become pub(crate), and current_url moves out of the #[store] block into the HistoryNav impl because the macro's private witness trait cannot be captured by an impl Readable return type.
The stack-machine writer only clears the mapping of the node being removed, so descendants keep (harmless) mappings to dropped generational ids; ElementIds are always re-mapped before they are pushed.
The dioxus-native prelude no longer aliases dioxus_html as dioxus_elements.
nicoburns
force-pushed
the
devin/1792776194-dioxus-0.8
branch
from
October 23, 2026 19:33
286edea to
615f979
Compare
nicoburns
enabled stacked auto-merge (squash)
October 23, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
dioxus-*/manganispins from0.7.3to0.8.0-alpha.3and copiespackages/native{,-dom}/srcfrom Dioxusmainoverpackages/dioxus-native{,-dom}/srcverbatim. After this the two repos' copies differ only in theversionlines and thestyle_threading: StyleThreading::Parallelsetting (#1243), which Dioxus picks up with its next Blitz pin bump.What the sync brings in (all of it needs
dioxus-core/dioxus-html0.8):WriteMutationsis the 0.8 stack machine (push_id/set_id/child/clone,BorrowedAttributeValue).mutation_writer.rsis nowStackWriter<R: RealDom>(id/stack bookkeeping) +BlitzBackend(real tree ops);DioxusStatekeepstry_element_to_node_id.mutation_buffer.rs:VirtualDom::rebuild/render_immediatewrite into aMutationBufferand the document is only borrowed afterwards, so tasks/effects polled during the render can useNodeHandles (testtask_polled_during_render_can_access_document).keyboard_compat.rsis deleted:dioxus-html0.8 uses keyboard-types 0.8, soBlitzKeyboardDataetc. pass values through.preludere-exportshtml,elements::prelude::*,NamedKey(dioxus#5927) instead of thedioxus_elementsalias.boolean_attributes_follow_their_value_after_mounttest is kept (ported onto the new writer), and the unusedrustc-hashdependency is dropped from both crates.Fallout outside the two crates:
Key::Enter→Key::Named(NamedKey::Enter)intodomvc,seven_guisand the browser.#[store] impl<Lens> Store<T, Lens>blocks carry their own visibility, so the browser's cross-module ones becomepub(crate).History::current_url -> impl Readable<..>cannot stay in a#[store]block until stores: let#[store]methods returnimpl Traitdioxus#5995 ships (E0446: the witness trait was private and the RPIT captures theSelf: Witness<__V>bound), so it moves into theHistoryNavimpl for now.tests/blitz-tests/tests/stale_node_mapping.rs:ElementId(raw)is no longer constructible, and the "no stale mappings" assertion no longer holds: the 0.8 writer clears the mapping of the removed node only (StackState::clear_mapping), while descendants keep mappings to dropped generational ids. That is harmless here (core re-maps anElementIdviaset_idbefore it is ever pushed, andget_noderejects dropped ids), so the two tests become no-panic tests in this PR. The stacked follow-up restores the invariant and the original tests.Verified locally:
cargo check --workspace --all-targets,cargo clippy --workspace --tests,cargo test -p dioxus-native-dom -p blitz-tests,cargo deny ... check licenses.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/8451be47ca9a4d89ac073c7243d2a30e
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/8451be47ca9a4d89ac073c7243d2a30e?variant=devin-insiders
Requested by: @nicoburns
WPT results
No changes in test results compared to
main.Generated by the WPT workflow.