Repository navigation
desktop: enable ico feature on image dependency - #5994
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#5989 reduced
dioxus-desktop'simagefeatures topng. Those features are only used by the publicicon_from_memory/icon_from_pathhelpers (the built-in default icon is pre-decoded RGBA and doesn't useimage), so after #5989 they could no longer decode.icoicons, the usual Windows icon format.This adds
ico(which also pulls inimage'sbmpdecoder; no extra crates) and documents on both helpers that they support PNG and ICO. Apps that need other formats can enable the matchingimagefeatures in their ownCargo.toml.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/e56d5b96a8ea436dafb6b660f3ee2250
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/e56d5b96a8ea436dafb6b660f3ee2250?variant=devin-insiders
Requested by: @nicoburns