Repository navigation
Allow transposing stores with non-Copy lenses - #6004
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6001.
Problem
The
transpose()method that#[derive(Store)]generates requiresSelf: Copy, for both structs and enums. A store of aHashMaporBTreeMapvalue uses aGetWrite<K, _>lens that holds the key. That lens isClonebut notCopywhen the key is notCopy(for example,String), so callingtranspose()on a map value store fails to compile:The same type works when it lives in a
Vec, because the index lens isCopy.Solution
transpose()fromSelf: CopytoSelf: Clone.CopyimpliesClone, so every call that compiles today still compiles.as_variant()accessors keep usingselfdirectly, so they gain no new bound.Testing
derive_transpose_non_copy_lenstopackages/stores/tests/macro.rs. It transposes struct and enum values fromHashMap<String, _>store fields.cargo test -p dioxus-stores --test macrofails with twoE0277errors (struct and enumtranspose). With the fix, it passes.cargo test -p dioxus-stores -p dioxus-stores-macropasses (including the trybuild UI tests).cargo fmt --checkandcargo clippy --all-targetsfor both crates are clean.