Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
#79 moved the icon to
comms-cli_512px.pngand deletedicons/comms-cli.png. Publishedtdcversions (latest is 3.6.0) still send the old raw GitHub URL aslogo_uriwhen they register, so every new registration since that merge stores a URL that returns 404, and Todoist never refreshes it. This puts the refreshed icon at the old path (same file ascomms-cli_512px.png), so those registrations show the new icon. Thefix:title cuts a release that ships the newLOGO_URIfrom #79.The old file can go once a release carrying the new
LOGO_URIhas been out long enough that new registrations no longer use the old URL.Reference
Follows #79.
Changelog
Fix the missing consent-screen icon for clients registered by older versions.
Test plan
https://raw.githubusercontent.com/doist/comms-cli/main/icons/comms-cli.pngonmainbefore this is merged.tdc auth loginusing a fresh config.