Fixes Naga-Taur Clothes Layering + Breasts not updating when chaning jumpsuit - #1146
Conversation
carda-sometimesknownas-paxilmaniac
left a comment
There was a problem hiding this comment.
under clothes layer
look inside
higher layer than clothes
00-Steven
left a comment
There was a problem hiding this comment.
for sanity's sake im gonna ask you to check breasts
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
I have checked my breasts and they are indeed fine now. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About The Pull Request
Someone reported that the bodysuit on a Naga did not render its front-facing sprites correctly and that immediately prompted me to fix that with no ulterior motive whatsoever. Which turns out was a bug with all naga clothing where it was being displayed on the wrong layer. Moves the layer down to 29.1 from 28.25, meaning they now render under the uniform layer. This doesn't cause any issues from testing with existing outfits. I've also moved the special tail appendeges up to FRONT instead of FRONT_UNDER so they render over clothing and over hands now.
The other taurs still do not display the bodysuit correctly but I was a bit stumped on the fix, as we can't move their layer down as it'd render their tails behind the mob's body sprite. Couldn't think of a proper resolution despite unpleasant fixes, such as moving the clothes layer forcefully up to go over the taurs (which feels bad to do and messes with backpacks).
Why It's Good For The Game
No longer are you wearing clothes only in 2D, now you are wearing them in all dimensions.
Testing Evidence
Changelog
🆑TheOneAndOnlyCreeperJoe
fix: Fixed naga tails rendering on the wrong layer when facing the front, resulting in naga-specific clothing not being visible
fix: Breasts now update properly when changing your undersuit slot.
/:cl: