Skip to content

Fixes Naga-Taur Clothes Layering + Breasts not updating when chaning jumpsuit - #1146

Open
TheOneAndOnlyCreeperJoe wants to merge 5 commits into
DopplerShift13:masterfrom
TheOneAndOnlyCreeperJoe:fixes_custom_taur_clothing
Open

Fixes Naga-Taur Clothes Layering + Breasts not updating when chaning jumpsuit#1146
TheOneAndOnlyCreeperJoe wants to merge 5 commits into
DopplerShift13:masterfrom
TheOneAndOnlyCreeperJoe:fixes_custom_taur_clothing

Conversation

@TheOneAndOnlyCreeperJoe

@TheOneAndOnlyCreeperJoe TheOneAndOnlyCreeperJoe commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

About The Pull Request

Someone reported that the bodysuit on a Naga did not render its front-facing sprites correctly and that immediately prompted me to fix that with no ulterior motive whatsoever. Which turns out was a bug with all naga clothing where it was being displayed on the wrong layer. Moves the layer down to 29.1 from 28.25, meaning they now render under the uniform layer. This doesn't cause any issues from testing with existing outfits. I've also moved the special tail appendeges up to FRONT instead of FRONT_UNDER so they render over clothing and over hands now.

The other taurs still do not display the bodysuit correctly but I was a bit stumped on the fix, as we can't move their layer down as it'd render their tails behind the mob's body sprite. Couldn't think of a proper resolution despite unpleasant fixes, such as moving the clothes layer forcefully up to go over the taurs (which feels bad to do and messes with backpacks).

Why It's Good For The Game

No longer are you wearing clothes only in 2D, now you are wearing them in all dimensions.

Testing Evidence

image

Changelog

🆑TheOneAndOnlyCreeperJoe
fix: Fixed naga tails rendering on the wrong layer when facing the front, resulting in naga-specific clothing not being visible
fix: Breasts now update properly when changing your undersuit slot.
/:cl:

@github-actions github-actions Bot added Sprites Funny little pixels on our screen Fix Pest removal; Bugs labels Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under clothes layer
look inside
higher layer than clothes

@00-Steven 00-Steven left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sanity's sake im gonna ask you to check breasts

/datum/bodypart_overlay/mutant/breasts
feature_key = FEATURE_BREASTS
layers = EXTERNAL_BODY_FRONT_UNDER_CLOTHES | EXTERNAL_BEHIND

@github-actions

Copy link
Copy Markdown

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions Bot added the Stale label Jul 27, 2026
@TheOneAndOnlyCreeperJoe TheOneAndOnlyCreeperJoe changed the title Fixes Naga-Taur Clothes Layering Fixes Naga-Taur Clothes Layering + Breasts not updating when chaning jumpsuit Jul 28, 2026
@TheOneAndOnlyCreeperJoe

TheOneAndOnlyCreeperJoe commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

for sanity's sake im gonna ask you to check breasts

/datum/bodypart_overlay/mutant/breasts
feature_key = FEATURE_BREASTS
layers = EXTERNAL_BODY_FRONT_UNDER_CLOTHES | EXTERNAL_BEHIND

I have checked my breasts and they are indeed fine now.
Added update_body_parts() to adjusting jumpsuits so now they properly hide and everything. I don't like it wholy as a solution but this is basically the price we pay for having body overlay mechanics?

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions Bot added the Stale label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Pest removal; Bugs Sprites Funny little pixels on our screen Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants