Security Hat is not Nanotrasen Anymore

[firebudgy]

About The Pull Request

Adjusts the security hat to have something more stylized for port security and not just be a nanotrasen hat. We're not Nanotrasen, we're PCAT and Security is Port Safety, not NT Security. Sprites visible below in Testing Evidence. Originally this was going to follow the other style of the hats but any symbol was distorted beyond recognition, and I eventually decided this was probably a better option.

Why It's Good For The Game

I don't like wearing a nanotrasen-branded hat trying to represent a wholly different organization, and the only other hats that aren't that are for medics and just plain non-security hats. This should make it so that it's less... strange, to be wearing one.

Testing Evidence

Changelog

🆑
add: New security cap sprite.
/:cl:

[00-Steven]

this is gonna need to be a modular override, we generally avoid editing base tg code and especially dmis where possible
this is because otherwise when we pull from upstream and anything changes those files it'll cause conflicts, and at best we'll struggle to work out which is ours and which is theirs
we often mark things with // DOPPLER EDIT [type] type comments if needed, but this we can do 100% modularly

that being, instead of editing the base tg files, we add an override in one of our modular folders and make it point to an entirely new icon dmi
you're gonna want to look probably here for where to put it instead:

DopplerShift/modular_doppler/modular_jobs/code/job_overrides/object_flavor/security.dm

Lines 15 to 28 in 5ddcb87

	/**
	* CLOTHING
	*/
	/obj/item/clothing/head/beret/sec
	name = "security beret"
	desc = "A robust beret with the Port Safety insignia emblazoned on it. Uses reinforced fabric to offer sufficient protection."
	/obj/item/clothing/head/beret/sec/navyofficer
	desc = "A special beret with the Port Safety insignia emblazoned on it. For guards with class."
	/obj/item/clothing/shoes/jackboots
	name = "jackboots"
	desc = "Port Safety issued Security combat boots for combat scenarios or combat situations. All combat, all the time."

and here for where to put the new dmis, with just the cap icons:
https://github.com/DopplerShift13/DopplerShift/tree/master/modular_doppler/modular_jobs/icons
in matching subfolders for mob/obj sprites ala the current mob/clothing/head/hats.dmi and obj/clothing/head/hats.dmi
then you'd add the override into the object_flavor/security.dm file like this:

/obj/item/clothing/head/soft/sec
	name = "security cap"
	desc = "It's a robust baseball hat in tasteful red colour, with the black and white roundel of Port Safety emblazoned on it."
	icon = [new obj icon file] //TODO: add location of new obj icon file
	worn_icon = [new mob icon file] //TODO: add location of new mob icon file
	icon_state = "secsoft"
	soft_type = "sec"

where you fill in the todo lines yourself
while the name, icon_state, and soft_type aren't NECESSARY to override because we're keeping them the same, it's generally better to do so in case base tg changes the icon state and ours breaks because our new dmi doesn't contain that icon state

otherwise, bluntly, I dislike how the front-facing cap items look as is, as with comments in the spriting channel ala feeling flat or being difficult to make out as a cap without already having that context
I don't feel the badge icon being perfect matters too much, more so than the overall shape being identifiable at a glance

[firebudgy]

While I would be willing to make all the changes mentioned, it is unfortunately out of my skillset to do -- I don't want to leave something open I can't finish, sorry!

[firebudgy]

Code reviews addressed -- I was encouraged to either way throw my (in this case literal) hat into the ring since anything is supposedly better than residual NT branding.

[firebudgy]

this is gonna need to be a modular override, we generally avoid editing base tg code and especially dmis where possible this is because otherwise when we pull from upstream and anything changes those files it'll cause conflicts, and at best we'll struggle to work out which is ours and which is theirs we often mark things with // DOPPLER EDIT [type] type comments if needed, but this we can do 100% modularly

Just a heads up @00-Steven I have ported this to Doppler's modular code and tested it - it works.

[firebudgy]

Hey, can I get a re-review?